Patchwork [v2] tracetool dtrace disabled-events fix

login
register
mail settings
Submitter Lee Essen
Date March 20, 2012, 5:02 p.m.
Message ID <4F68B830.9040008@nowonline.co.uk>
Download mbox | patch
Permalink /patch/147813/
State New
Headers show

Comments

Lee Essen - March 20, 2012, 5:02 p.m.
If there are "disabled" entries in the trace-events file then
linetod_nop() is called if the backend is dtrace, it's currently
not present. Also equivalent fix for stap.

Signed-off-by: Lee Essen<lee.essen@nowonline.co.uk>

--
Stefan Hajnoczi - March 21, 2012, 10:47 a.m.
On Tue, Mar 20, 2012 at 05:02:40PM +0000, Lee Essen wrote:
> If there are "disabled" entries in the trace-events file then
> linetod_nop() is called if the backend is dtrace, it's currently
> not present. Also equivalent fix for stap.
> 
> Signed-off-by: Lee Essen<lee.essen@nowonline.co.uk>
> 
> --

Thanks, applied to the tracing patches tree:
https://github.com/stefanha/qemu/commits/tracing

Note that this patch has whitespace damage.  I hat to apply it manually
because git-am(1) would not accept it.  Please check your patch sending
process - using git-send-email(1) works best and shouldn't mangle
whitespace.

Also please use "Lee Essen <lee.essen@nowonline.co.uk>" with a space
between the name and email address.  I'm not sure if any parsers have
problems when the space is missing, but it normally needs to be there.

Stefan

Patch

diff --git a/scripts/tracetool b/scripts/tracetool
index 65bd0a1..a279c2c 100755
--- a/scripts/tracetool
+++ b/scripts/tracetool
@@ -161,6 +161,18 @@  linetoc_nop()
      return
  }

+linetod_nop()
+{
+    # Used when "disabled" events are processed
+    return
+}
+
+linetostap_nop()
+{
+    # Used when "disabled" events are processed
+    return
+}
+
  linetoc_end_nop()
  {
      return