Patchwork tracetool dtrace disabled-events fix

login
register
mail settings
Submitter Lee Essen
Date March 20, 2012, 1:37 p.m.
Message ID <4F688831.5050709@nowonline.co.uk>
Download mbox | patch
Permalink /patch/147791/
State New
Headers show

Comments

Lee Essen - March 20, 2012, 1:37 p.m.
If there are "disabled" entries in the trace-events file then
linetod_nop() is called if the backend is dtrace, it's currently
not present.

Signed-off-by: Lee Essen <lee.essen@nowonline.co.uk>

--
Stefan Hajnoczi - March 20, 2012, 4:42 p.m.
On Tue, Mar 20, 2012 at 1:37 PM, Lee Essen <lee.essen@nowonline.co.uk> wrote:
> If there are "disabled" entries in the trace-events file then
> linetod_nop() is called if the backend is dtrace, it's currently
> not present.
>
> Signed-off-by: Lee Essen <lee.essen@nowonline.co.uk>
>
> --
> diff --git a/scripts/tracetool b/scripts/tracetool
> index 65bd0a1..d5e5591 100755
> --- a/scripts/tracetool
> +++ b/scripts/tracetool
> @@ -161,6 +161,12 @@ linetoc_nop()
>     return
>  }
>
> +linetod_nop()
> +{
> +    # Used when "disabled" events are processed
> +    return
> +}

Please also add linetostap_nop() for SystemTap builds - the nop
function was missing there too.

Otherwise looks good.

Stefan

Patch

diff --git a/scripts/tracetool b/scripts/tracetool
index 65bd0a1..d5e5591 100755
--- a/scripts/tracetool
+++ b/scripts/tracetool
@@ -161,6 +161,12 @@  linetoc_nop()
      return
  }

+linetod_nop()
+{
+    # Used when "disabled" events are processed
+    return
+}
+
  linetoc_end_nop()
  {
      return