| Message ID | 14f530e2802146eb78e690eef5a868394bfdf66a.1332197811.git.quintela@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 19 March 2012 22:57, Juan Quintela <quintela@redhat.com> wrote: > +/* 32 bit float */ > + > +typedef union { > + float32 f; > + uint32_t i; > +} VMStateFloat32; > + > +static int get_float32(QEMUFile *f, void *pv, size_t size) > +{ > + float32 *v = pv; > + VMStateFloat32 u; > + qemu_get_be32s(f, &u.i); > + *v = u.f; > + return 0; > +} > + > +static void put_float32(QEMUFile *f, void *pv, size_t size) > +{ > + float32 *v = pv; > + VMStateFloat32 u; > + u.f = *v; > + qemu_put_be32s(f, &u.i); > +} This conversion (float32<->uint32_t) should be done via float32_val() and make_float32(). -- PMM
Peter Maydell <peter.maydell@linaro.org> wrote: > On 19 March 2012 22:57, Juan Quintela <quintela@redhat.com> wrote: >> +/* 32 bit float */ >> + >> +typedef union { >> + float32 f; >> + uint32_t i; >> +} VMStateFloat32; >> + >> +static int get_float32(QEMUFile *f, void *pv, size_t size) >> +{ >> + float32 *v = pv; >> + VMStateFloat32 u; >> + qemu_get_be32s(f, &u.i); >> + *v = u.f; >> + return 0; >> +} >> + >> +static void put_float32(QEMUFile *f, void *pv, size_t size) >> +{ >> + float32 *v = pv; >> + VMStateFloat32 u; >> + u.f = *v; >> + qemu_put_be32s(f, &u.i); >> +} > > This conversion (float32<->uint32_t) should be done via > float32_val() and make_float32(). you are right. we can even simplify things with this. Thanks.
diff --git a/savevm.c b/savevm.c index 12fb209..09a2149 100644 --- a/savevm.c +++ b/savevm.c @@ -1082,6 +1082,36 @@ const VMStateInfo vmstate_info_uint16_equal = { .put = put_uint16, }; +/* 32 bit float */ + +typedef union { + float32 f; + uint32_t i; +} VMStateFloat32; + +static int get_float32(QEMUFile *f, void *pv, size_t size) +{ + float32 *v = pv; + VMStateFloat32 u; + qemu_get_be32s(f, &u.i); + *v = u.f; + return 0; +} + +static void put_float32(QEMUFile *f, void *pv, size_t size) +{ + float32 *v = pv; + VMStateFloat32 u; + u.f = *v; + qemu_put_be32s(f, &u.i); +} + +const VMStateInfo vmstate_info_float32 = { + .name = "float32", + .get = get_float32, + .put = put_float32, +}; + /* timers */ static int get_timer(QEMUFile *f, void *pv, size_t size) diff --git a/vmstate.h b/vmstate.h index 1a4a60b..135c5aa 100644 --- a/vmstate.h +++ b/vmstate.h @@ -130,6 +130,8 @@ extern const VMStateInfo vmstate_info_uint16; extern const VMStateInfo vmstate_info_uint32; extern const VMStateInfo vmstate_info_uint64; +extern const VMStateInfo vmstate_info_float32; + extern const VMStateInfo vmstate_info_timer; extern const VMStateInfo vmstate_info_buffer; extern const VMStateInfo vmstate_info_unused_buffer; @@ -559,6 +561,9 @@ extern const VMStateDescription vmstate_cpu; #define VMSTATE_INT64_ARRAY(_f, _s, _n) \ VMSTATE_INT64_ARRAY_V(_f, _s, _n, 0) +#define VMSTATE_FLOAT32_ARRAY(_f, _s, _n) \ + VMSTATE_ARRAY(_f, _s, _n, 0, vmstate_info_float32, float32) + #define VMSTATE_BUFFER_V(_f, _s, _v) \ VMSTATE_STATIC_BUFFER(_f, _s, _v, NULL, 0, sizeof(typeof_field(_s, _f)))
Signed-off-by: Juan Quintela <quintela@redhat.com> --- savevm.c | 30 ++++++++++++++++++++++++++++++ vmstate.h | 5 +++++ 2 files changed, 35 insertions(+), 0 deletions(-)