diff mbox

net: qmi_wwan: fix build error due to cdc-wdm dependecy

Message ID 1332179309-4163-1-git-send-email-bjorn@mork.no
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Bjørn Mork March 19, 2012, 5:48 p.m. UTC
Fixes:

drivers/built-in.o: In function `qmi_wwan_bind_shared':
qmi_wwan.c:(.text+0x25b686): undefined reference to `usb_cdc_wdm_register'
make[1]: *** [.tmp_vmlinux1] Error 1

Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
Thanks for noticing.

This should have been in commit c3ecb08a
 net: qmi_wwan: support devices having a shared QMI/wwan interface


Bjørn


 drivers/net/usb/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Randy.Dunlap March 19, 2012, 8:16 p.m. UTC | #1
On 03/19/2012 10:48 AM, Bjørn Mork wrote:

> Fixes:
> 
> drivers/built-in.o: In function `qmi_wwan_bind_shared':
> qmi_wwan.c:(.text+0x25b686): undefined reference to `usb_cdc_wdm_register'
> make[1]: *** [.tmp_vmlinux1] Error 1
> 
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>


Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.


> ---
> Thanks for noticing.
> 
> This should have been in commit c3ecb08a
>  net: qmi_wwan: support devices having a shared QMI/wwan interface
> 
> 
> Bjørn
> 
> 
>  drivers/net/usb/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 4bad899..833e32f 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -401,6 +401,7 @@ config USB_NET_KALMIA
>  config USB_NET_QMI_WWAN
>  	tristate "QMI WWAN driver for Qualcomm MSM based 3G and LTE modems"
>  	depends on USB_USBNET
> +	select USB_WDM
>  	help
>  	  Support WWAN LTE/3G devices based on Qualcomm Mobile Data Modem
>  	  (MDM) chipsets.  Examples of such devices are
David Miller March 19, 2012, 10:17 p.m. UTC | #2
From: Randy Dunlap <rdunlap@xenotime.net>
Date: Mon, 19 Mar 2012 13:16:55 -0700

> On 03/19/2012 10:48 AM, Bjørn Mork wrote:
> 
>> Fixes:
>> 
>> drivers/built-in.o: In function `qmi_wwan_bind_shared':
>> qmi_wwan.c:(.text+0x25b686): undefined reference to `usb_cdc_wdm_register'
>> make[1]: *** [.tmp_vmlinux1] Error 1
>> 
>> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
>> Signed-off-by: Bjørn Mork <bjorn@mork.no>
> 
> 
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 4bad899..833e32f 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -401,6 +401,7 @@  config USB_NET_KALMIA
 config USB_NET_QMI_WWAN
 	tristate "QMI WWAN driver for Qualcomm MSM based 3G and LTE modems"
 	depends on USB_USBNET
+	select USB_WDM
 	help
 	  Support WWAN LTE/3G devices based on Qualcomm Mobile Data Modem
 	  (MDM) chipsets.  Examples of such devices are