From patchwork Mon Mar 19 17:43:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Carlini X-Patchwork-Id: 147599 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id BCD24B6FF3 for ; Tue, 20 Mar 2012 04:46:44 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1332784006; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Message-ID:Date:From:User-Agent:MIME-Version: To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=yPZ3XBKtqaBnt1ldNqHace7oG1o=; b=bc8gJTdv8/o1fKv53tu3DatYyZ69C4kCKqX6WoL41cFUiVDx8RcyWnevNBA6xW PjjTRtPWC2kyX3pN+U+z076eUTBIWgnQxPzOXl6ouhqBgDN6GL37ueQhskFBMnpY /Eu1gigIXcXBf7QCkA0PZ6Jez9B8bEPEGNyS4fU0s0odM= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=F1/aAir66Qx3r7bZcj6YPVcvc9f+wh4G7vYGDgtoOhCVz5Ej4pl5B2VOU1tZbO IY+IA4N8Ls0IcEM47E+6ReHJsVs1I8KAkxcUCbytr7nnYnx0PxEkmq9mBDDhFWhk EaltGo/rU2zy/tb6BmyzhS+JLufBmLkAIH4v+LDF62Kbc=; Received: (qmail 26558 invoked by alias); 19 Mar 2012 17:46:39 -0000 Received: (qmail 26539 invoked by uid 22791); 19 Mar 2012 17:46:37 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from acsinet15.oracle.com (HELO acsinet15.oracle.com) (141.146.126.227) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Mar 2012 17:45:58 +0000 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q2JHjtfE029088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Mar 2012 17:45:56 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q2JHjsNo005053 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 19 Mar 2012 17:45:55 GMT Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q2JHjsUd008721; Mon, 19 Mar 2012 12:45:54 -0500 Received: from [192.168.1.4] (/79.51.11.15) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 19 Mar 2012 10:45:54 -0700 Message-ID: <4F677025.9030203@oracle.com> Date: Mon, 19 Mar 2012 18:43:01 +0100 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2 MIME-Version: 1.0 To: Jason Merrill CC: "gcc-patches@gcc.gnu.org" Subject: Re: [C++ Patch] PR 14710 (add -Wuseless-cast) References: <4F63B3DF.8060701@oracle.com> <4F64B5E5.2020502@redhat.com> <4F66001D.9030500@oracle.com> <4F6731D2.7080909@redhat.com> <4F673A57.6040108@oracle.com> <4F6749BB.7000400@redhat.com> In-Reply-To: <4F6749BB.7000400@redhat.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 03/19/2012 03:59 PM, Jason Merrill wrote: > OK. Thanks. I committed the patch. I'm going to add, as obvious, the following few additional tests, which my previous iteration got wrong. Paolo. ////////////////// 2012-03-19 Paolo Carlini * g++.dg/warn/Wuseless-cast.C: Extend. Index: testsuite/g++.dg/warn/Wuseless-cast.C =================================================================== --- testsuite/g++.dg/warn/Wuseless-cast.C (revision 185528) +++ testsuite/g++.dg/warn/Wuseless-cast.C (working copy) @@ -58,6 +58,8 @@ template dynamic_cast(t); } +A prvalue(); + void f() { int n; @@ -90,6 +92,10 @@ void f() #ifdef __GXX_EXPERIMENTAL_CXX0X__ (int&&)(42); static_cast(42); + + (A&&)(prvalue()); + const_cast(prvalue()); + static_cast(prvalue()); #endif A a;