Patchwork ext4: remove useless s_dirt assignment

login
register
mail settings
Submitter Artem Bityutskiy
Date March 19, 2012, 12:50 p.m.
Message ID <1332161448-1355-1-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/147503/
State Superseded
Headers show

Comments

Artem Bityutskiy - March 19, 2012, 12:50 p.m.
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Clean-up ext4 a tiny bit by removing useless s_dirt assignment in
'ext4_fill_super()' because a bit later we anyway call 'ext4_setup_super()'
which writes the superblock to the media unconditionally.

I would not bother removing the assignment, but I am prepare the code for
further s_dirt clean-ups.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 fs/ext4/super.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index c1f5111..d280bb6 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3415,7 +3415,6 @@  static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 #else
 		es->s_flags |= cpu_to_le32(EXT2_FLAGS_SIGNED_HASH);
 #endif
-		sb->s_dirt = 1;
 	}
 
 	/* Handle clustersize */