From patchwork Fri Mar 16 19:01:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Kleen X-Patchwork-Id: 147244 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3BC2CB6EEE for ; Sat, 17 Mar 2012 06:04:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756554Ab2CPTDk (ORCPT ); Fri, 16 Mar 2012 15:03:40 -0400 Received: from mga09.intel.com ([134.134.136.24]:62958 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755719Ab2CPTBL (ORCPT ); Fri, 16 Mar 2012 15:01:11 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 16 Mar 2012 12:01:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="118439716" Received: from tassilo.jf.intel.com ([10.7.201.151]) by orsmga001.jf.intel.com with ESMTP; 16 Mar 2012 12:01:08 -0700 Received: by tassilo.jf.intel.com (Postfix, from userid 501) id DBC25240FAC; Fri, 16 Mar 2012 12:01:07 -0700 (PDT) From: Andi Kleen To: linux-kernel@vger.kernel.org Cc: Andi Kleen , netdev@vger.kernel.org, samuel@sortiz.org Subject: [PATCH 08/11] irda: remove spin_is_locked Date: Fri, 16 Mar 2012 12:01:01 -0700 Message-Id: <1331924464-18023-9-git-send-email-andi@firstfloor.org> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1331924464-18023-1-git-send-email-andi@firstfloor.org> References: <1331924464-18023-1-git-send-email-andi@firstfloor.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andi Kleen It's hard to imagine how this spin_is_locked debugging check is not totally racy. Remove it. Cc: netdev@vger.kernel.org Cc: samuel@sortiz.org Signed-off-by: Andi Kleen --- drivers/net/irda/sir_dev.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/irda/sir_dev.c b/drivers/net/irda/sir_dev.c index 5039f08..90a1b3e 100644 --- a/drivers/net/irda/sir_dev.c +++ b/drivers/net/irda/sir_dev.c @@ -632,11 +632,6 @@ static netdev_tx_t sirdev_hard_xmit(struct sk_buff *skb, /* Init tx buffer*/ dev->tx_buff.data = dev->tx_buff.head; - /* Check problems */ - if(spin_is_locked(&dev->tx_lock)) { - IRDA_DEBUG(3, "%s(), write not completed\n", __func__); - } - /* serialize with write completion */ spin_lock_irqsave(&dev->tx_lock, flags);