Patchwork [V8,RESEND,1/8] pci_ids: Add INTEL_82599_VF id.

login
register
mail settings
Submitter Anthony PERARD
Date March 16, 2012, 4:54 p.m.
Message ID <1331916862-20504-2-git-send-email-anthony.perard@citrix.com>
Download mbox | patch
Permalink /patch/147221/
State New
Headers show

Comments

Anthony PERARD - March 16, 2012, 4:54 p.m.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 hw/pci_ids.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Stefano Stabellini - March 19, 2012, 11:50 a.m.
On Fri, 16 Mar 2012, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  hw/pci_ids.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> index e8235a7..943106a 100644
> --- a/hw/pci_ids.h
> +++ b/hw/pci_ids.h
> @@ -118,6 +118,7 @@
>  #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939
>  #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a
>  #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c
> +#define PCI_DEVICE_ID_INTEL_82599_VF     0x10ed

maybe it should be PCI_DEVICE_ID_INTEL_82599_SFP_VF for consistency with
Linux?
Anthony PERARD - March 19, 2012, 4:54 p.m.
On 19/03/12 11:50, Stefano Stabellini wrote:
> On Fri, 16 Mar 2012, Anthony PERARD wrote:
>> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
>> ---
>>   hw/pci_ids.h |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
>> index e8235a7..943106a 100644
>> --- a/hw/pci_ids.h
>> +++ b/hw/pci_ids.h
>> @@ -118,6 +118,7 @@
>>   #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939
>>   #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a
>>   #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c
>> +#define PCI_DEVICE_ID_INTEL_82599_VF     0x10ed
>
> maybe it should be PCI_DEVICE_ID_INTEL_82599_SFP_VF for consistency with
> Linux?

Ok, I'll change that.

Regards,
Konrad Rzeszutek Wilk - May 12, 2012, 1:43 a.m.
On Mon, Mar 19, 2012 at 12:54 PM, Anthony PERARD
<anthony.perard@citrix.com> wrote:
> On 19/03/12 11:50, Stefano Stabellini wrote:
>>
>> On Fri, 16 Mar 2012, Anthony PERARD wrote:
>>>
>>> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
>>> ---
>>>  hw/pci_ids.h |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
>>> index e8235a7..943106a 100644
>>> --- a/hw/pci_ids.h
>>> +++ b/hw/pci_ids.h
>>> @@ -118,6 +118,7 @@
>>>  #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939
>>>  #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a
>>>  #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c
>>> +#define PCI_DEVICE_ID_INTEL_82599_VF     0x10ed
>>
>>
>> maybe it should be PCI_DEVICE_ID_INTEL_82599_SFP_VF for consistency with
>> Linux?
>
>
> Ok, I'll change that.
>

And can you add why you need this?
Anthony PERARD - May 14, 2012, 10:52 a.m.
On Sat, May 12, 2012 at 2:43 AM, Konrad Rzeszutek Wilk
<konrad@darnok.org> wrote:
> On Mon, Mar 19, 2012 at 12:54 PM, Anthony PERARD
> <anthony.perard@citrix.com> wrote:
>> On 19/03/12 11:50, Stefano Stabellini wrote:
>>>
>>> On Fri, 16 Mar 2012, Anthony PERARD wrote:
>>>>
>>>> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
>>>> ---
>>>>  hw/pci_ids.h |    1 +
>>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
>>>> index e8235a7..943106a 100644
>>>> --- a/hw/pci_ids.h
>>>> +++ b/hw/pci_ids.h
>>>> @@ -118,6 +118,7 @@
>>>>  #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939
>>>>  #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a
>>>>  #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c
>>>> +#define PCI_DEVICE_ID_INTEL_82599_VF     0x10ed
>>>
>>>
>>> maybe it should be PCI_DEVICE_ID_INTEL_82599_SFP_VF for consistency with
>>> Linux?
>>
>>
>> Ok, I'll change that.
>>
>
> And can you add why you need this?

Done in the V11.

Patch

diff --git a/hw/pci_ids.h b/hw/pci_ids.h
index e8235a7..943106a 100644
--- a/hw/pci_ids.h
+++ b/hw/pci_ids.h
@@ -118,6 +118,7 @@ 
 #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939
 #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a
 #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c
+#define PCI_DEVICE_ID_INTEL_82599_VF     0x10ed
 
 #define PCI_VENDOR_ID_XEN               0x5853
 #define PCI_DEVICE_ID_XEN_PLATFORM      0x0001