[U-Boot,v4,20/27] Add x86 fields to generic global_data

Submitted by Simon Glass on March 15, 2012, 2:16 a.m.

Details

Message ID 1331777784-8528-21-git-send-email-sjg@chromium.org
State Changes Requested, archived
Headers show

Commit Message

Simon Glass March 15, 2012, 2:16 a.m.
These fields are needed for x86.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 include/asm-generic/global_data.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Graeme Russ March 15, 2012, 2:36 a.m.
Hi Simon,

On Thu, Mar 15, 2012 at 1:16 PM, Simon Glass <sjg@chromium.org> wrote:
> These fields are needed for x86.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  include/asm-generic/global_data.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h
> index 6199926..fb976f9 100644
> --- a/include/asm-generic/global_data.h
> +++ b/include/asm-generic/global_data.h
> @@ -44,6 +44,8 @@ typedef struct global_data {
>        bd_t            *bd;
>        unsigned long   flags;
>        unsigned long   baudrate;
> +       unsigned long   cpu_clk;        /* CPU clock in Hz!             */
> +       unsigned long   bus_clk;

Refer to my other comment, but this impacts all arches for no good reason

Regards,

Graeme
Simon Glass March 15, 2012, 2:54 a.m.
Hi Graeme,

On Wed, Mar 14, 2012 at 7:36 PM, Graeme Russ <graeme.russ@gmail.com> wrote:
> Hi Simon,
>
> On Thu, Mar 15, 2012 at 1:16 PM, Simon Glass <sjg@chromium.org> wrote:
>> These fields are needed for x86.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>>  include/asm-generic/global_data.h |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h
>> index 6199926..fb976f9 100644
>> --- a/include/asm-generic/global_data.h
>> +++ b/include/asm-generic/global_data.h
>> @@ -44,6 +44,8 @@ typedef struct global_data {
>>        bd_t            *bd;
>>        unsigned long   flags;
>>        unsigned long   baudrate;
>> +       unsigned long   cpu_clk;        /* CPU clock in Hz!             */
>> +       unsigned long   bus_clk;
>
> Refer to my other comment, but this impacts all arches for no good reason

See my other reply. Let me just add that these values would be pretty
useful to most archs.

Regards,
Simon

>
> Regards,
>
> Graeme

Patch hide | download patch | download mbox

diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h
index 6199926..fb976f9 100644
--- a/include/asm-generic/global_data.h
+++ b/include/asm-generic/global_data.h
@@ -44,6 +44,8 @@  typedef struct global_data {
 	bd_t		*bd;
 	unsigned long	flags;
 	unsigned long	baudrate;
+	unsigned long	cpu_clk;	/* CPU clock in Hz!		*/
+	unsigned long	bus_clk;
 #if defined(CONFIG_LCD) || defined(CONFIG_VIDEO)
 	unsigned long	fb_base;	/* Base address of framebuffer mem */
 #endif