Patchwork [net-next,4/4] cdc_ncm: remove redundant header files

login
register
mail settings
Submitter Alexey Orishko
Date March 14, 2012, 9:26 p.m.
Message ID <1331760373-1914-4-git-send-email-alexey.orishko@stericsson.com>
Download mbox | patch
Permalink /patch/146721/
State Rejected
Delegated to: David Miller
Headers show

Comments

Alexey Orishko - March 14, 2012, 9:26 p.m.
Signed-off-by: Alexey Orishko <alexey.orishko@stericsson.com>
---
 drivers/net/usb/cdc_ncm.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
David Miller - March 16, 2012, 9:08 a.m.
From: Alexey Orishko <alexey.orishko@gmail.com>
Date: Wed, 14 Mar 2012 22:26:13 +0100

> Signed-off-by: Alexey Orishko <alexey.orishko@stericsson.com>

I'm not applying this.

> -#include <linux/ethtool.h>

This file does very much do use the types in ethtool.h

I have a feeling you weren't very meticulious about this change
and basically said "it compiles, must be good".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 7adc9f6..9040fc2 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -39,13 +39,8 @@ 
  */
 
 #include <linux/module.h>
-#include <linux/init.h>
 #include <linux/netdevice.h>
-#include <linux/ctype.h>
-#include <linux/ethtool.h>
-#include <linux/workqueue.h>
 #include <linux/mii.h>
-#include <linux/crc32.h>
 #include <linux/usb.h>
 #include <linux/hrtimer.h>
 #include <linux/atomic.h>