Patchwork Man page: Add -global description

login
register
mail settings
Submitter Miroslav Rezanina
Date March 13, 2012, 6:09 p.m.
Message ID <20585aca-cce1-4305-9ef8-69e51321930c@zmail17.collab.prod.int.phx2.redhat.com>
Download mbox | patch
Permalink /patch/146464/
State New
Headers show

Comments

Miroslav Rezanina - March 13, 2012, 6:09 p.m.
There's only TODO information in qemu man page for -global option. This is a basic description of this option with simple example.

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>

Patch:
--
Paolo Bonzini - March 14, 2012, 7:42 a.m.
Il 13/03/2012 19:09, Miroslav Rezanina ha scritto:
> +@example
> +qemu -global ide-drive.physical_block_size=524 -drive file=file,if=ide,index=0,media=disk
> +@end example

Let's use something that works, such as 4096 instead of 524. :)

Paolo
Miroslav Rezanina - March 14, 2012, 7:54 a.m.
----- Original Message -----
> From: "Paolo Bonzini" <pbonzini@redhat.com>
> To: "Miroslav Rezanina" <mrezanin@redhat.com>
> Cc: qemu-devel@nongnu.org
> Sent: Wednesday, March 14, 2012 8:42:00 AM
> Subject: Re: Man page: Add -global description
> 
> Il 13/03/2012 19:09, Miroslav Rezanina ha scritto:
> > +@example
> > +qemu -global ide-drive.physical_block_size=524 -drive
> > file=file,if=ide,index=0,media=disk
> > +@end example
> 
> Let's use something that works, such as 4096 instead of 524. :)
> 
> Paolo
> 

Yeah, I was thinking what value to use - 524 was choosed as non-standard
but used value. However, you're right - something more standard would be
probably better and 4096 is the best candidate.

Mirek

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index daefce3..56d8c78 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -292,9 +292,13 @@  DEF("global", HAS_ARG, QEMU_OPTION_global,
     "                set a global default for a driver property\n",
     QEMU_ARCH_ALL)
 STEXI
-@item -global
+@item -global @var{driver}.@var{property}=@var{value}
 @findex -global
-TODO
+Set a default value of the @var{driver}'s @var{property} to the @var{value}, e.g.:
+
+@example
+qemu -global ide-drive.physical_block_size=524 -drive file=file,if=ide,index=0,media=disk
+@end example
 ETEXI
 
 DEF("mtdblock", HAS_ARG, QEMU_OPTION_mtdblock,