From patchwork Tue Mar 13 16:21:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 146441 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id F2BDBB6EF3 for ; Wed, 14 Mar 2012 03:21:59 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1332260520; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:Date:Message-ID:Subject:From:To: Cc:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=2nQI8q3 WLvJA65v4iRAksKIAssM=; b=bS/phRSlwfzjEeV7teijktGxDERjr2HovH5wVkm 9uAR5BBnj5TazP0xC8zckdBYNamnXb7lWrxUgF9Fud0o2VSZmhjpuoTSMbKMvfyr n8uHwYqWM8GptpKtPkwOa7dlEw3xmhIRzfLkpa2kz1rOrvVtiGurmLTfC16RH9Ml tmR4= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:Date:Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=sEk5jJRzuML19IY7Y4EdflLVUymAhLlvBW7/96D4G5FKPBR+NIFlAgfOwE49qy rEnF0/zfiuV8mOXaJODiel+9bUPG3rI7nljOamic+WLYcmME053ieTFI3CuJ66Wk o5fD9cle+D2UFCeodjbQ+zmTQrzcmI5NJIBn5Jk/pqNbQ=; Received: (qmail 1652 invoked by alias); 13 Mar 2012 16:21:51 -0000 Received: (qmail 1637 invoked by uid 22791); 13 Mar 2012 16:21:49 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-gx0-f175.google.com (HELO mail-gx0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Mar 2012 16:21:34 +0000 Received: by ggcy3 with SMTP id y3so764829ggc.20 for ; Tue, 13 Mar 2012 09:21:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.116.73 with SMTP id f49mr17679271yhh.97.1331655694010; Tue, 13 Mar 2012 09:21:34 -0700 (PDT) Received: by 10.146.241.18 with HTTP; Tue, 13 Mar 2012 09:21:33 -0700 (PDT) Date: Tue, 13 Mar 2012 17:21:33 +0100 Message-ID: Subject: [PATCH, i386]: Handle subregs of AND zero extended address correctly From: Uros Bizjak To: gcc-patches@gcc.gnu.org Cc: "H.J. Lu" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello! We allow addresses, zero extended with (AND (Dimode OP) (0x0ffffffff)). Since we now track address mode precisely, we should convert this operand to a SImode subreg before passing it further down of ix86_decompose_address function. This fixes a small hole, where operands in wrong mode could squeeze through. 2012-03-13 Uros Bizjak * config/i386/i386.c (ix86_decompose_address): Handle subregs of AND zero extended address correctly. Tested on x86_64-pc-linux-gnu {,-m32}, committed to mainline SVN. Uros. Index: i386.c =================================================================== --- i386.c (revision 185327) +++ i386.c (working copy) @@ -11435,10 +11435,14 @@ ix86_decompose_address (rtx addr, struct ix86_addr { addr = XEXP (addr, 0); - /* Strip subreg. */ - if (GET_CODE (addr) == SUBREG - && GET_MODE (SUBREG_REG (addr)) == SImode) + /* Adjust SUBREGs. */ + if (GET_MODE (addr) == DImode) + addr = gen_rtx_SUBREG (SImode, addr, 0); + else if (GET_CODE (addr) == SUBREG + && GET_MODE (SUBREG_REG (addr)) == SImode) addr = SUBREG_REG (addr); + else + return 0; } }