Patchwork ide: IDENTIFY word 86 bit 14 is reserved

login
register
mail settings
Submitter Kevin Wolf
Date March 13, 2012, 1:49 p.m.
Message ID <1331646595-24650-1-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/146412/
State New
Headers show

Comments

Kevin Wolf - March 13, 2012, 1:49 p.m.
Reserved bits should be cleared to zero.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/ide/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Hajnoczi - March 14, 2012, 9:35 a.m.
On Tue, Mar 13, 2012 at 1:49 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Reserved bits should be cleared to zero.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  hw/ide/core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index 6f06d28..771811c 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -150,7 +150,7 @@ static void ide_identify(IDEState *s)
>     else
>          put_le16(p + 85, (1 << 14) | 1);
>     /* 13=flush_cache_ext,12=flush_cache,10=lba48 */
> -    put_le16(p + 86, (1 << 14) | (1 << 13) | (1 <<12) | (1 << 10));
> +    put_le16(p + 86, (1 << 13) | (1 <<12) | (1 << 10));

Looks good.  This seems like a copy-paste bug in "LBA48 support (Jens
Axboe)" (c2ff060fd4c7389de2016442e3327538a66696bd) where words 83 and
86 were modified in the same way.

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Patch

diff --git a/hw/ide/core.c b/hw/ide/core.c
index 6f06d28..771811c 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -150,7 +150,7 @@  static void ide_identify(IDEState *s)
     else
          put_le16(p + 85, (1 << 14) | 1);
     /* 13=flush_cache_ext,12=flush_cache,10=lba48 */
-    put_le16(p + 86, (1 << 14) | (1 << 13) | (1 <<12) | (1 << 10));
+    put_le16(p + 86, (1 << 13) | (1 <<12) | (1 << 10));
     /* 14=set to 1, 1=smart self test, 0=smart error logging */
     put_le16(p + 87, (1 << 14) | 0);
     put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported */