From patchwork Tue Mar 13 09:38:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 146374 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 91868B6F13 for ; Tue, 13 Mar 2012 20:38:45 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1332236327; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=94IRBNqflCevWQAO6W/03Rlb62w=; b=VGjBSpcTaGSvwxq j6NFSoFRFXxumfu/NFYShlLfDS+oltnOHO4dnwQjIiby2QM0cj4vnzO5uqok3KJH /GJBQbcGzADWtAQg9qVzuhGkPRki5bFnhlW2Y8MHx0ptXdRvvWGeavyQYfeQlQBQ t5P2RjNTJnJLb0NSw0WiG2EGacg4= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Cc:Subject:In-Reply-To:Message-ID:References:User-Agent:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=HOfwisdysDtEGUI/dZgEqwhRruvxZR8KQVCeYad5+z+mWP1jHBd/wnP4cWa0NW zDgJ7XtOvbKt62CrOMZ67pEaSS9bp9e7Ksn2OmSBN6UMS8/HlUo3BKCLElX+ZbNu XMdNDnLVBW5te5Zhp0DuyfpaXOn9KELK1KzHqEKGLf6rE=; Received: (qmail 13114 invoked by alias); 13 Mar 2012 09:38:40 -0000 Received: (qmail 13105 invoked by uid 22791); 13 Mar 2012 09:38:39 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Mar 2012 09:38:24 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 787C7A3A2C; Tue, 13 Mar 2012 10:38:23 +0100 (CET) Date: Tue, 13 Mar 2012 10:38:23 +0100 (CET) From: Richard Guenther To: David Edelsohn Cc: GCC Patches Subject: Re: libgcc gcov_fork failure on AIX In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Mon, 12 Mar 2012, David Edelsohn wrote: > Richi, > > Your patch for PR gcov/49484 now causes a bootstrap failure on AIX: > > /farm/dje/src/src/libgcc/libgcov.c: In function '__gcov_fork': > /farm/dje/src/src/libgcc/libgcov.c:1008:5: error: 'mx' undeclared > (first use in this function) > /farm/dje/src/src/libgcc/libgcov.c:1008:5: note: each undeclared > identifier is reported only once for each function it appears in > make: *** [_gcov_fork.o] Error 1 > > # 1000 "/farm/dje/src/src/libgcc/libgcov.c" > pid_t > __gcov_fork (void) > { > pid_t pid; > extern __gthread_mutex_t __gcov_flush_mx; > __gcov_flush (); > pid = fork (); > if (pid == 0) > (mx) (&__gcov_flush_mx); > return pid; > } Fixed with the following, applied as obvious. Richard. 2012-03-13 Richard Guenther * gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Fix definition. Index: libgcc/gthr-single.h =================================================================== --- libgcc/gthr-single.h (revision 185319) +++ libgcc/gthr-single.h (working copy) @@ -36,7 +36,7 @@ typedef int __gthread_recursive_mutex_t; #define __GTHREAD_ONCE_INIT 0 #define __GTHREAD_MUTEX_INIT 0 -#define __GTHREAD_MUTEX_INIT_FUNCTION (mx) +#define __GTHREAD_MUTEX_INIT_FUNCTION(mx) #define __GTHREAD_RECURSIVE_MUTEX_INIT 0 #define UNUSED __attribute__((unused))