Patchwork MIPS: Kbuild: remove -Werror

login
register
mail settings
Submitter Artem Bityutskiy
Date March 9, 2012, 11:35 a.m.
Message ID <1331292947-14913-1-git-send-email-dedekind1@gmail.com>
Download mbox | patch
Permalink /patch/146297/
State New
Headers show

Comments

Artem Bityutskiy - March 9, 2012, 11:35 a.m.
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

MIPS does not build with the standard W=1 Kbuild switch with - tested with
gcc-4.6 by me and gcc-4.5 by John Crispin. The reason is that MIPS adds
-Werror build option.

This patch removes the option to make W=1 work. I do compile-tests for various
architecture before accepting MTD patches and I have scripts which build before
applying the patch, then after, and then compare 2 build logs and report about
new warnings. I use W=1 to see more warnings in the logs diff. And from my
perspective all platforms should build with W=1.

The other way would be to fix all warnings, but there are false positives, and
it is too difficult to maintain the code warning-free, so it is easier to just
remove -Werror.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 arch/mips/Kbuild |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
Artem Bityutskiy - March 21, 2012, 2:01 p.m.
On Fri, 2012-03-09 at 13:35 +0200, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> 
> MIPS does not build with the standard W=1 Kbuild switch with - tested with
> gcc-4.6 by me and gcc-4.5 by John Crispin. The reason is that MIPS adds

Hi Ralf,

what's the fate of this patch?

Patch

diff --git a/arch/mips/Kbuild b/arch/mips/Kbuild
index 7dd65cf..0d37730 100644
--- a/arch/mips/Kbuild
+++ b/arch/mips/Kbuild
@@ -1,8 +1,3 @@ 
-# Fail on warnings - also for files referenced in subdirs
-# -Werror can be disabled for specific files using:
-# CFLAGS_<file.o> := -Wno-error
-subdir-ccflags-y := -Werror
-
 # platform specific definitions
 include arch/mips/Kbuild.platforms
 obj-y := $(platform-y)