Patchwork drivers/mtd: docg3 fix writebufsize

login
register
mail settings
Submitter Robert Jarzmik
Date March 11, 2012, 10:28 a.m.
Message ID <1331461726-10087-2-git-send-email-robert.jarzmik@free.fr>
Download mbox | patch
Permalink /patch/146279/
State New
Headers show

Comments

Robert Jarzmik - March 11, 2012, 10:28 a.m.
The docg3 drivers lacked mtd writebufsize initialization. Without it,
ubifs cannot work.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 drivers/mtd/devices/docg3.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Artem Bityutskiy - March 13, 2012, 11:48 a.m.
On Sun, 2012-03-11 at 11:28 +0100, Robert Jarzmik wrote:
> The docg3 drivers lacked mtd writebufsize initialization. Without it,
> ubifs cannot work.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>

I think I've already done this in the l2-mtd.git tree. I strongly
recommend you to test on top of the l2-mtd.git because it has the latest
stuff.
Robert Jarzmik - March 13, 2012, 8:50 p.m.
Artem Bityutskiy <dedekind1@gmail.com> writes:

> On Sun, 2012-03-11 at 11:28 +0100, Robert Jarzmik wrote:
>> The docg3 drivers lacked mtd writebufsize initialization. Without it,
>> ubifs cannot work.
>> 
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> I think I've already done this in the l2-mtd.git tree. I strongly
> recommend you to test on top of the l2-mtd.git because it has the latest
> stuff.

OK, will do.

Cheers.

Patch

diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index bd9e992..c30b56a 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1822,6 +1822,7 @@  static void __init doc_set_driver_info(int chip_id, struct mtd_info *mtd)
 	if (docg3->reliable == 2)
 		mtd->erasesize /= 2;
 	mtd->writesize = DOC_LAYOUT_PAGE_SIZE;
+	mtd->writebufsize = DOC_LAYOUT_PAGE_SIZE;
 	mtd->oobsize = DOC_LAYOUT_OOB_SIZE;
 	mtd->owner = THIS_MODULE;
 	mtd->erase = doc_erase;