Patchwork monitor: Remove unused bool field 'qapi' in mon_cmd_t struct

login
register
mail settings
Submitter Jeff Cody
Date March 12, 2012, 6:13 p.m.
Message ID <14fd588cffd843789d6b6a4379f42ac1b2a6fbbf.1331575674.git.jcody@redhat.com>
Download mbox | patch
Permalink /patch/146192/
State New
Headers show

Comments

Jeff Cody - March 12, 2012, 6:13 p.m.
Some minor code cleanup: the 'qapi' bool field in mon_cmd_t is
unused, and can be removed.

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 monitor.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Luiz Capitulino - March 13, 2012, 1:37 p.m.
On Mon, 12 Mar 2012 14:13:57 -0400
Jeff Cody <jcody@redhat.com> wrote:

> Some minor code cleanup: the 'qapi' bool field in mon_cmd_t is
> unused, and can be removed.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>

Acked-by: Luiz Capitulino <lcapitulino@redhat.com>

> ---
>  monitor.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/monitor.c b/monitor.c
> index a787aab..34272eb 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -128,7 +128,6 @@ typedef struct mon_cmd_t {
>          int  (*cmd_async)(Monitor *mon, const QDict *params,
>                            MonitorCompletion *cb, void *opaque);
>      } mhandler;
> -    bool qapi;
>      int flags;
>  } mon_cmd_t;
>
Stefan Hajnoczi - March 15, 2012, 10:33 a.m.
On Mon, Mar 12, 2012 at 02:13:57PM -0400, Jeff Cody wrote:
> Some minor code cleanup: the 'qapi' bool field in mon_cmd_t is
> unused, and can be removed.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  monitor.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/monitor.c b/monitor.c
index a787aab..34272eb 100644
--- a/monitor.c
+++ b/monitor.c
@@ -128,7 +128,6 @@  typedef struct mon_cmd_t {
         int  (*cmd_async)(Monitor *mon, const QDict *params,
                           MonitorCompletion *cb, void *opaque);
     } mhandler;
-    bool qapi;
     int flags;
 } mon_cmd_t;