Patchwork Re[2]: linux-next: Tree for Mar 9 (netfilter)

login
register
mail settings
Submitter Hans Schillstrom
Date March 11, 2012, 12:37 p.m.
Message ID <giupeu1.ee21a87813f836d9f587ea0b0e19a695@obelix.schillstrom.com>
Download mbox | patch
Permalink /patch/145977/
State Rejected
Headers show

Comments

Hans Schillstrom - March 11, 2012, 12:37 p.m.
Hello
>On Fri, Mar 09, 2012 at 12:30:42PM -0800, Randy Dunlap wrote:
>> On 03/09/2012 12:11 AM, Stephen Rothwell wrote:
>> 
>> > Hi all,
>> > 
>> > There will be no linux-next release on March 12 due to a public holiday.
>> > 
>> > Changes since 20120308:
>> 
>> 
>> xt_LOG.c:(.text+0x789b1): undefined reference to `ip6t_ext_hdr'
>> 
>> Full randconfig file is attached.
>
>The patch attached fixes this problem, thanks!


This one is needed as well,

To force xt_LOG  to be configured as a module if ipv6 is a module,
otherwise you end up in the same linking problem

Signed-off-by: Hans Schillstrom <hans@schillstrom.com>
---
 net/netfilter/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Pablo Neira - March 11, 2012, 3:52 p.m.
Hi Hans,

On Sun, Mar 11, 2012 at 01:37:25PM +0100, Hans Schillstrom wrote:
> Hello
> >On Fri, Mar 09, 2012 at 12:30:42PM -0800, Randy Dunlap wrote:
> >> On 03/09/2012 12:11 AM, Stephen Rothwell wrote:
> >>
> >> > Hi all,
> >> >
> >> > There will be no linux-next release on March 12 due to a public holiday.
> >> >
> >> > Changes since 20120308:
> >>
> >>
> >> xt_LOG.c:(.text+0x789b1): undefined reference to `ip6t_ext_hdr'
> >>
> >> Full randconfig file is attached.
> >
> >The patch attached fixes this problem, thanks!
> 
> 
> This one is needed as well,
> 
> To force xt_LOG  to be configured as a module if ipv6 is a module,
> otherwise you end up in the same linking problem

Perhaps I'm missing anything but either way (IPv6 as module or
built-in) the symbol is still defined. With my patch applied, xt_LOG
now depends on IP6_NF_IPTABLES, which depends on IPV6.

Moreover we've got other xt_ target and matches that contain both IPv4
and IPv6 support that don't require this.

Let me know.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 0c6f67e..4ef9c80 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -547,6 +547,7 @@  config NETFILTER_XT_TARGET_LED
 
 config NETFILTER_XT_TARGET_LOG
 	tristate "LOG target support"
+	depends on (IPV6 || IPV6=n)
 	default m if NETFILTER_ADVANCED=n
 	help
 	  This option adds a `LOG' target, which allows you to create rules in