Patchwork [v2,2/2] ata: AT91 ata driver requires AT91_HAS_PATA

login
register
mail settings
Submitter Alan Ott
Date March 10, 2012, 9:39 p.m.
Message ID <1331415562-10994-1-git-send-email-alan@signal11.us>
Download mbox | patch
Permalink /patch/145902/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Alan Ott - March 10, 2012, 9:39 p.m.
This driver uses registers defined in a per-soc header file.
Since not every soc in the at91 platform defines those, make
the Kconfig option dependent on those which define
AT91_HAS_PATA.

This is based on a patch by Arnd Bergmann.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alan Ott <alan@signal11.us>
CC: Ben Dooks <ben-linux@fluff.org>
---
 drivers/ata/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Sergei Shtylyov - March 11, 2012, 10:10 a.m.
Hello.

On 11-03-2012 1:39, Alan Ott wrote:

> This driver uses registers defined in a per-soc header file.
> Since not every soc in the at91 platform defines those, make
> the Kconfig option dependent on those which define
> AT91_HAS_PATA.

> This is based on a patch by Arnd Bergmann.

> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
> Signed-off-by: Alan Ott<alan@signal11.us>
> CC: Ben Dooks<ben-linux@fluff.org>
> ---
>   drivers/ata/Kconfig |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)

> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 6bdedd7..fdb8c90 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -731,6 +731,7 @@ config PATA_AT32
>   config PATA_AT91
>   	tristate "PATA support for AT91SAM9260"
>   	depends on ARM && ARCH_AT91

    Is this line still needed?

> +	depends on AT91_HAS_PATA
>   	help
>   	  This option enables support for IDE devices on the Atmel AT91SAM9260 SoC.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - March 13, 2012, 8:46 p.m.
On 03/10/2012 04:39 PM, Alan Ott wrote:
> This driver uses registers defined in a per-soc header file.
> Since not every soc in the at91 platform defines those, make
> the Kconfig option dependent on those which define
> AT91_HAS_PATA.
>
> This is based on a patch by Arnd Bergmann.
>
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
> Signed-off-by: Alan Ott<alan@signal11.us>
> CC: Ben Dooks<ben-linux@fluff.org>
> ---
>   drivers/ata/Kconfig |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 6bdedd7..fdb8c90 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -731,6 +731,7 @@ config PATA_AT32
>   config PATA_AT91
>   	tristate "PATA support for AT91SAM9260"
>   	depends on ARM&&  ARCH_AT91
> +	depends on AT91_HAS_PATA
>   	help

Acked-by: Jeff Garzik <jgarzik@redhat.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 6bdedd7..fdb8c90 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -731,6 +731,7 @@  config PATA_AT32
 config PATA_AT91
 	tristate "PATA support for AT91SAM9260"
 	depends on ARM && ARCH_AT91
+	depends on AT91_HAS_PATA
 	help
 	  This option enables support for IDE devices on the Atmel AT91SAM9260 SoC.