Patchwork [1/1] ata: AT91 ata driver requires specific platforms

login
register
mail settings
Submitter Alan Ott
Date March 10, 2012, 6:54 p.m.
Message ID <1331405652-4100-1-git-send-email-alan@signal11.us>
Download mbox | patch
Permalink /patch/145893/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Alan Ott - March 10, 2012, 6:54 p.m.
From: Arnd Bergmann <arnd@arndb.de>

This driver uses registers defined in a per-soc header file.
Since not every soc in the at91 platform defines those, make
the Kconfig option dependent on specifically the socs that
do.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alan Ott <alan@signal11.us>
---
 drivers/ata/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Ben Dooks - March 10, 2012, 7:56 p.m.
On Sat, Mar 10, 2012 at 01:54:12PM -0500, Alan Ott wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver uses registers defined in a per-soc header file.
> Since not every soc in the at91 platform defines those, make
> the Kconfig option dependent on specifically the socs that
> do.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Alan Ott <alan@signal11.us>
> ---
>  drivers/ata/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 6bdedd7..16c6b78 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -731,6 +731,7 @@ config PATA_AT32
>  config PATA_AT91
>  	tristate "PATA support for AT91SAM9260"
>  	depends on ARM && ARCH_AT91
> +	depends on ARCH_AT91SAM9260 || ARCH_AT91SAM9G20 || ARCH_AT91SAM9261 ||  ARCH_AT91SAM9G10 || ARCH_AT91SAM9263 || ARCH_AT91SAM9RL || ARCH_AT91SAM9G45 || ARCH_AT91CAP9
>  	help

How about adding an AT91_HAS_PATA kconfig and having the arch/arm/... Kconfig
select it as necessary. It will avoid future fun when another device comes
out.

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 6bdedd7..16c6b78 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -731,6 +731,7 @@  config PATA_AT32
 config PATA_AT91
 	tristate "PATA support for AT91SAM9260"
 	depends on ARM && ARCH_AT91
+	depends on ARCH_AT91SAM9260 || ARCH_AT91SAM9G20 || ARCH_AT91SAM9261 ||  ARCH_AT91SAM9G10 || ARCH_AT91SAM9263 || ARCH_AT91SAM9RL || ARCH_AT91SAM9G45 || ARCH_AT91CAP9
 	help
 	  This option enables support for IDE devices on the Atmel AT91SAM9260 SoC.