From patchwork Sat Mar 10 11:21:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 145850 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 66A42B6F98 for ; Sat, 10 Mar 2012 22:22:04 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1331983328; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=BulphKBq7sXMV0DjnJsC1DmS35g=; b=tx4i24++6DYEXNVcuIdshxJ2wtOnoSHYKj6gDg+KEcRZgnuE8CiFLZVUfMPvus BS5L7UEi/S4Zkht9xQ6r6nmeMW4w5efAV+dPbloZs5+9ZwdURuKMe/3VOUuJiXnk ajilHYxljCupab6QvTb4eagPiWZP7m1xO4BBHNt5omc+A= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Rq5IUoeGmT6PP8cyRA7zZDGUMFtMFoLfbCPiBumyRgoPPAv4Etr30Nm9s+6c2z rCw/Gn4S3qOPgPI+OXTqkSbgRAE8feM8pspd+AeRPp4knoG4HODbBD8ntr1mzX1S MfwMGL6PEXTK0vYP9AiR489zGsc9vYX7zM+YNcRQ6RWl0=; Received: (qmail 1416 invoked by alias); 10 Mar 2012 11:21:50 -0000 Received: (qmail 1393 invoked by uid 22791); 10 Mar 2012 11:21:49 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yw0-f47.google.com (HELO mail-yw0-f47.google.com) (209.85.213.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Mar 2012 11:21:34 +0000 Received: by yhjj56 with SMTP id j56so1618242yhj.20 for ; Sat, 10 Mar 2012 03:21:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.236.176.163 with SMTP id b23mr6397960yhm.122.1331378493618; Sat, 10 Mar 2012 03:21:33 -0800 (PST) Received: by 10.101.126.19 with HTTP; Sat, 10 Mar 2012 03:21:33 -0800 (PST) In-Reply-To: <4F5B2AAD.2040009@net-b.de> References: <4F5B2AAD.2040009@net-b.de> Date: Sat, 10 Mar 2012 12:21:33 +0100 Message-ID: Subject: Re: Many regressions with: [patch] Cleanup fortran/convert.c From: Steven Bosscher To: Tobias Burnus Cc: GCC Patches , fortran@gcc.gnu.org X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sat, Mar 10, 2012 at 11:19 AM, Tobias Burnus wrote: > Steven Bosscher wrote: >> >> This cleans up some remnants of the ancestors of fortran's convert.c, >> which was copied from GNAT IIRC. I would bootstrap&test this, but trunk >> appears to be broken for x86_64-linux right now (ICE in patch_jump_insn). >> But I can post this >> for review, at least. >> OK for trunk, after bootstrap+test? > > > Your patch seems to have caused many Fortran regressions. At least I see > with 185156 only one (known) failure, cf. > http://gcc.gnu.org/ml/gcc-testresults/2012-03/msg01069.html > > While starting with 185160 there are many, many gfortran failures, cf. > http://gcc.gnu.org/ml/gcc-testresults/2012-03/msg01073.html Yes, it seems that different boolean types aren't allowed. I must have looked at the wrong test results somehow. I'm testing this fix: Index: convert.c =================================================================== --- convert.c (revision 185160) +++ convert.c (working copy) @@ -95,7 +95,8 @@ convert (tree type, tree expr) if (code == VOID_TYPE) return fold_build1_loc (input_location, CONVERT_EXPR, type, e); if (code == BOOLEAN_TYPE) - return truthvalue_conversion (e); + return fold_build1_loc (input_location, NOP_EXPR, type, + truthvalue_conversion (e)); if (code == INTEGER_TYPE) return fold (convert_to_integer (type, e)); if (code == POINTER_TYPE || code == REFERENCE_TYPE)