Patchwork [RFC,v4,09/44] hw/mc146818: Drop unneeded #includes

login
register
mail settings
Submitter Andreas Färber
Date March 10, 2012, 2:27 a.m.
Message ID <1331346496-10736-10-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/145811/
State New
Headers show

Comments

Andreas Färber - March 10, 2012, 2:27 a.m.
pc.h and apic.h are not needed; apic.h would drag in x86 CPUState and
is now included directly for TARGET_I386.

isa.h is already #included from mc146818rtc.h.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 hw/mc146818rtc.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Anthony Liguori - March 13, 2012, 6:07 p.m.
On 03/09/2012 08:27 PM, Andreas Färber wrote:
> pc.h and apic.h are not needed; apic.h would drag in x86 CPUState and
> is now included directly for TARGET_I386.
>
> isa.h is already #included from mc146818rtc.h.

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

>
> Signed-off-by: Andreas Färber<afaerber@suse.de>
> ---
>   hw/mc146818rtc.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index 8b5cf8c..2b59c36 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -24,8 +24,6 @@
>   #include "hw.h"
>   #include "qemu-timer.h"
>   #include "sysemu.h"
> -#include "pc.h"
> -#include "isa.h"
>   #include "mc146818rtc.h"
>
>   #ifdef TARGET_I386

Patch

diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 8b5cf8c..2b59c36 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -24,8 +24,6 @@ 
 #include "hw.h"
 #include "qemu-timer.h"
 #include "sysemu.h"
-#include "pc.h"
-#include "isa.h"
 #include "mc146818rtc.h"
 
 #ifdef TARGET_I386