Patchwork Swap SECTION_EXCLUDE and SECTION_MACH_DEP

login
register
mail settings
Submitter Sriraman Tallam
Date March 9, 2012, 11:10 p.m.
Message ID <CAAs8Hmxf+hW5bn+YnGzAL+z0EFHUiuoPcVc5jjy+-UBEcXzeOA@mail.gmail.com>
Download mbox | patch
Permalink /patch/145777/
State New
Headers show

Comments

Sriraman Tallam - March 9, 2012, 11:10 p.m.
Please see:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52545

SECTION_EXCLUDE should not take up bits reserved for SECTION_MACH_DEP

Patch:

	PR 52545
	* output.h (SECTION_MACH_DEP)
	(SECTION_EXCLUDE):  Swap values.




Thanks.
-Sri.


On Fri, Mar 9, 2012 at 3:07 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>
Sriraman Tallam - March 12, 2012, 5:26 p.m.
Hi Richard,

  Is this ok for trunk? Asking you because you approved the patch the
first time around.

Thanks,
-Sri.

On Fri, Mar 9, 2012 at 3:10 PM, Sriraman Tallam <tmsriram@google.com> wrote:
> Please see:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52545
>
> SECTION_EXCLUDE should not take up bits reserved for SECTION_MACH_DEP
>
> Patch:
>
>        PR 52545
>        * output.h (SECTION_MACH_DEP)
>        (SECTION_EXCLUDE):  Swap values.
>
>
>
> Index: output.h
> ===================================================================
> --- output.h    (revision 185120)
> +++ output.h    (working copy)
> @@ -446,8 +446,8 @@
>  #define SECTION_STYLE_MASK 0x600000    /* bits used for SECTION_STYLE */
>  #define SECTION_COMMON   0x800000      /* contains common data */
>  #define SECTION_RELRO   0x1000000      /* data is readonly after relocation
> processing */
> -#define SECTION_MACH_DEP 0x2000000     /* subsequent bits reserved for target */
> -#define SECTION_EXCLUDE  0x4000000      /* discarded by the linker */
> +#define SECTION_EXCLUDE  0x2000000      /* discarded by the linker */
> +#define SECTION_MACH_DEP 0x4000000     /* subsequent bits reserved for target */
>
> Ok to submit?
>
> Thanks.
> -Sri.
>
>
> On Fri, Mar 9, 2012 at 3:07 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>>
Richard Henderson - March 12, 2012, 5:27 p.m.
On 03/12/12 10:26, Sriraman Tallam wrote:
> Hi Richard,
> 
>   Is this ok for trunk? Asking you because you approved the patch the
> first time around.
> 
> Thanks,
> -Sri.
> 
> On Fri, Mar 9, 2012 at 3:10 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>> Please see:
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52545
>>
>> SECTION_EXCLUDE should not take up bits reserved for SECTION_MACH_DEP
>>
>> Patch:
>>
>>        PR 52545
>>        * output.h (SECTION_MACH_DEP)
>>        (SECTION_EXCLUDE):  Swap values.


Yes, this patch is ok


r~
Sriraman Tallam - March 12, 2012, 6:29 p.m.
Already submitted by gjl in rev. 185259.

-Sri.

On Mon, Mar 12, 2012 at 10:27 AM, Richard Henderson <rth@redhat.com> wrote:
> On 03/12/12 10:26, Sriraman Tallam wrote:
>> Hi Richard,
>>
>>   Is this ok for trunk? Asking you because you approved the patch the
>> first time around.
>>
>> Thanks,
>> -Sri.
>>
>> On Fri, Mar 9, 2012 at 3:10 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>>> Please see:
>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52545
>>>
>>> SECTION_EXCLUDE should not take up bits reserved for SECTION_MACH_DEP
>>>
>>> Patch:
>>>
>>>        PR 52545
>>>        * output.h (SECTION_MACH_DEP)
>>>        (SECTION_EXCLUDE):  Swap values.
>
>
> Yes, this patch is ok
>
>
> r~

Patch

Index: output.h
===================================================================
--- output.h	(revision 185120)
+++ output.h	(working copy)
@@ -446,8 +446,8 @@ 
 #define SECTION_STYLE_MASK 0x600000	/* bits used for SECTION_STYLE */
 #define SECTION_COMMON   0x800000	/* contains common data */
 #define SECTION_RELRO	 0x1000000	/* data is readonly after relocation
processing */
-#define SECTION_MACH_DEP 0x2000000	/* subsequent bits reserved for target */
-#define SECTION_EXCLUDE  0x4000000      /* discarded by the linker */
+#define SECTION_EXCLUDE  0x2000000      /* discarded by the linker */
+#define SECTION_MACH_DEP 0x4000000	/* subsequent bits reserved for target */

Ok to submit?