From patchwork Fri Mar 9 15:57:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: arm highbank: force ramsize to INT_MAX when loading Date: Fri, 09 Mar 2012 05:57:40 -0000 From: Mark Langsdorf X-Patchwork-Id: 145735 Message-Id: <1331308660-20787-1-git-send-email-mark.langsdorf@calxeda.com> To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Mark Langsdorf , agraf@suse.de, armbru@redhat.com, eblake@redhat.com, afaerber@suse.de, david@gibson.dropbear.id.au Since the ram_size field of arm_boot_info is only an int, don't set that field to more than INT_MAX. Signed vs unsigned comparison overruns are possible otherwise. Signed-off-by: Mark Langsdorf --- hw/highbank.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/highbank.c b/hw/highbank.c index 489c00e..577284a 100644 --- a/hw/highbank.c +++ b/hw/highbank.c @@ -306,7 +306,7 @@ static void highbank_init(ram_addr_t ram_size, sysbus_connect_irq(sysbus_from_qdev(dev), 2, pic[82]); } - highbank_binfo.ram_size = ram_size; + highbank_binfo.ram_size = (ram_size < INT_MAX ? ram_size : INT_MAX); highbank_binfo.kernel_filename = kernel_filename; highbank_binfo.kernel_cmdline = kernel_cmdline; highbank_binfo.initrd_filename = initrd_filename;