Patchwork [1/1] maint-getabis: added ppc64 to the patterns list to be ignored

login
register
mail settings
Submitter Luis Henriques
Date March 8, 2012, 9:12 p.m.
Message ID <1331241143-12009-2-git-send-email-luis.henriques@canonical.com>
Download mbox | patch
Permalink /patch/145629/
State New
Headers show

Comments

Luis Henriques - March 8, 2012, 9:12 p.m.
The ppc64 is a powerpc flavour that has actually never been supported.  However,
the maint-getabis checks it for certain Ubuntu series, whenever this flavour is
listed on the debian/control* files.

The following series are impacted with this patch:
 - lucid
 - natty
 - oneiric
 - precise

Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
 maintscripts/maint-getabis |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Tim Gardner - March 8, 2012, 9:50 p.m.
On 03/08/2012 02:12 PM, Luis Henriques wrote:
> The ppc64 is a powerpc flavour that has actually never been supported.  However,
> the maint-getabis checks it for certain Ubuntu series, whenever this flavour is
> listed on the debian/control* files.
>
> The following series are impacted with this patch:
>   - lucid
>   - natty
>   - oneiric
>   - precise
>
> Signed-off-by: Luis Henriques<luis.henriques@canonical.com>
> ---
>   maintscripts/maint-getabis |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/maintscripts/maint-getabis b/maintscripts/maint-getabis
> index 74bcd72..6505ec9 100755
> --- a/maintscripts/maint-getabis
> +++ b/maintscripts/maint-getabis
> @@ -26,7 +26,10 @@ from buildenv_lib import *
>   IgnorePatterns = dict()
>   IgnorePatterns["dapper" ] = [ ".*_xen.deb", ".*iseries-smp.*" ]
>   IgnorePatterns["karmic" ] = [ ".*dove-z0.*" ]
> -IgnorePatterns["lucid"] = [ ".*_lpia.deb" ]
> +IgnorePatterns["lucid"] = [ ".*_lpia.deb", ".*_ppc64.deb ]
> +IgnorePatterns["natty"] = [".*_ppc64.deb" ]
> +IgnorePatterns["oneiric"] = [".*_ppc64.deb" ]
> +IgnorePatterns["precise"] = [".*_ppc64.deb" ]
>
>   #------------------------------------------------------------------------------
>   # Setup the command line parser and run it.

Herton - Why are we using kteam-tools/maintscripts/maint-getabis when 
every release and branch has a debian/scripts/misc/getabis that is 
tailored specifically for that set of kernels?

rtg
Luis Henriques - March 8, 2012, 10:14 p.m.
On Thu, Mar 08, 2012 at 02:50:41PM -0700, Tim Gardner wrote:
> Herton - Why are we using kteam-tools/maintscripts/maint-getabis
> when every release and branch has a debian/scripts/misc/getabis that
> is tailored specifically for that set of kernels?

Ah, interesting!  I wasn't aware of this tailored version of the script.

So, in that case what actually needs to be changed is the maint-startnewrelease
which uses the kteam-tools maint-getabis script.  Maybe it should first check if
the debian/scripts/misc/getabis script exists and defaults to the kteam-tools if
it doesn't.

Cheers,
Andy Whitcroft - March 8, 2012, 10:15 p.m.
On Thu, Mar 08, 2012 at 02:50:41PM -0700, Tim Gardner wrote:

> Herton - Why are we using kteam-tools/maintscripts/maint-getabis
> when every release and branch has a debian/scripts/misc/getabis that
> is tailored specifically for that set of kernels?

maint-getabits knows how to use a remote machine to extract the ABI
inforamtion to avoid downloading all the binary .deb files to the local
machine.

-apw
Herton Ronaldo Krzesinski - March 9, 2012, 12:06 a.m.
On Thu, Mar 08, 2012 at 10:15:11PM +0000, Andy Whitcroft wrote:
> On Thu, Mar 08, 2012 at 02:50:41PM -0700, Tim Gardner wrote:
> 
> > Herton - Why are we using kteam-tools/maintscripts/maint-getabis
> > when every release and branch has a debian/scripts/misc/getabis that
> > is tailored specifically for that set of kernels?
> 
> maint-getabits knows how to use a remote machine to extract the ABI
> inforamtion to avoid downloading all the binary .deb files to the local
> machine.

Also maint-getabis can take the debs from canonical-kernel-team ppa,
while debian.master/etc/getabis doesn't have the entries to do that, not
sure if it would be desirable to have it, I need it when I have to do a
startnewrelease on master-next without having to wait to packages to be
copied to -proposed (archive).

> 
> -apw
>
Herton Ronaldo Krzesinski - March 9, 2012, 12:08 a.m.
On Thu, Mar 08, 2012 at 09:12:23PM +0000, Luis Henriques wrote:
> The ppc64 is a powerpc flavour that has actually never been supported.  However,
> the maint-getabis checks it for certain Ubuntu series, whenever this flavour is
> listed on the debian/control* files.
> 
> The following series are impacted with this patch:
>  - lucid
>  - natty
>  - oneiric
>  - precise
> 
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
>  maintscripts/maint-getabis |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/maintscripts/maint-getabis b/maintscripts/maint-getabis
> index 74bcd72..6505ec9 100755
> --- a/maintscripts/maint-getabis
> +++ b/maintscripts/maint-getabis
> @@ -26,7 +26,10 @@ from buildenv_lib import *
>  IgnorePatterns = dict()
>  IgnorePatterns["dapper" ] = [ ".*_xen.deb", ".*iseries-smp.*" ]
>  IgnorePatterns["karmic" ] = [ ".*dove-z0.*" ]
> -IgnorePatterns["lucid"] = [ ".*_lpia.deb" ]
> +IgnorePatterns["lucid"] = [ ".*_lpia.deb", ".*_ppc64.deb ]

We don't need it on Lucid, doesn't have the ppc64 arch.

> +IgnorePatterns["natty"] = [".*_ppc64.deb" ]
> +IgnorePatterns["oneiric"] = [".*_ppc64.deb" ]
> +IgnorePatterns["precise"] = [".*_ppc64.deb" ]
>  
>  #------------------------------------------------------------------------------
>  # Setup the command line parser and run it.
> -- 
> 1.7.9
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Stefan Bader - March 9, 2012, 10:09 a.m.
On 08.03.2012 22:12, Luis Henriques wrote:
> The ppc64 is a powerpc flavour that has actually never been supported.  However,
> the maint-getabis checks it for certain Ubuntu series, whenever this flavour is
> listed on the debian/control* files.
> 
> The following series are impacted with this patch:
>  - lucid
>  - natty
>  - oneiric
>  - precise
> 
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
>  maintscripts/maint-getabis |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/maintscripts/maint-getabis b/maintscripts/maint-getabis
> index 74bcd72..6505ec9 100755
> --- a/maintscripts/maint-getabis
> +++ b/maintscripts/maint-getabis
> @@ -26,7 +26,10 @@ from buildenv_lib import *
>  IgnorePatterns = dict()
>  IgnorePatterns["dapper" ] = [ ".*_xen.deb", ".*iseries-smp.*" ]
>  IgnorePatterns["karmic" ] = [ ".*dove-z0.*" ]
> -IgnorePatterns["lucid"] = [ ".*_lpia.deb" ]
> +IgnorePatterns["lucid"] = [ ".*_lpia.deb", ".*_ppc64.deb ]
> +IgnorePatterns["natty"] = [".*_ppc64.deb" ]
> +IgnorePatterns["oneiric"] = [".*_ppc64.deb" ]
> +IgnorePatterns["precise"] = [".*_ppc64.deb" ]
>  
>  #------------------------------------------------------------------------------
>  # Setup the command line parser and run it.

Yes, Herton is right. It would not hurt but I removed lucid before applying and
pushing.

-Stefan

Patch

diff --git a/maintscripts/maint-getabis b/maintscripts/maint-getabis
index 74bcd72..6505ec9 100755
--- a/maintscripts/maint-getabis
+++ b/maintscripts/maint-getabis
@@ -26,7 +26,10 @@  from buildenv_lib import *
 IgnorePatterns = dict()
 IgnorePatterns["dapper" ] = [ ".*_xen.deb", ".*iseries-smp.*" ]
 IgnorePatterns["karmic" ] = [ ".*dove-z0.*" ]
-IgnorePatterns["lucid"] = [ ".*_lpia.deb" ]
+IgnorePatterns["lucid"] = [ ".*_lpia.deb", ".*_ppc64.deb ]
+IgnorePatterns["natty"] = [".*_ppc64.deb" ]
+IgnorePatterns["oneiric"] = [".*_ppc64.deb" ]
+IgnorePatterns["precise"] = [".*_ppc64.deb" ]
 
 #------------------------------------------------------------------------------
 # Setup the command line parser and run it.