From patchwork Thu Mar 8 15:37:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 145553 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B4C0EB6EEE for ; Fri, 9 Mar 2012 02:39:27 +1100 (EST) Received: from localhost ([::1]:33331 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5fR7-0002r3-LS for incoming@patchwork.ozlabs.org; Thu, 08 Mar 2012 10:39:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5fQC-0001Lo-Fg for qemu-devel@nongnu.org; Thu, 08 Mar 2012 10:38:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5fPl-0001ay-Rl for qemu-devel@nongnu.org; Thu, 08 Mar 2012 10:38:28 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:60171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5fPl-0001aE-Jc for qemu-devel@nongnu.org; Thu, 08 Mar 2012 10:38:01 -0500 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Mar 2012 15:37:57 -0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (9.149.38.129) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 8 Mar 2012 15:37:38 -0000 Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q28FbbbO1687596 for ; Thu, 8 Mar 2012 15:37:38 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q28FbYbX028451 for ; Thu, 8 Mar 2012 08:37:34 -0700 Received: from localhost (stefanha-thinkpad.manchester-maybrook.uk.ibm.com [9.174.219.44]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q28FbXNd028435; Thu, 8 Mar 2012 08:37:34 -0700 From: Stefan Hajnoczi To: Anthony Liguori Date: Thu, 8 Mar 2012 15:37:17 +0000 Message-Id: <1331221041-4710-8-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.9.1 In-Reply-To: <1331221041-4710-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1331221041-4710-1-git-send-email-stefanha@linux.vnet.ibm.com> x-cbid: 12030815-2966-0000-0000-0000037531FE X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 195.75.94.109 Cc: Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 07/11] vnc: Add break statement X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Stefan Weil This was not a bug, but it is not common practice to omit the break statement from the last case statement before an empty default case. Any change of the default case would introduce a bug. This was reported as a warning by splint. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- ui/vnc-enc-hextile-template.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h index b9f9f5e..a7310e1 100644 --- a/ui/vnc-enc-hextile-template.h +++ b/ui/vnc-enc-hextile-template.h @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs, /* we really don't have to invalidate either the bg or fg but we've lost the old values. oh well. */ } + break; default: break; }