Patchwork [07/11] vnc: Add break statement

login
register
mail settings
Submitter Stefan Hajnoczi
Date March 8, 2012, 3:37 p.m.
Message ID <1331221041-4710-8-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/145553/
State New
Headers show

Comments

Stefan Hajnoczi - March 8, 2012, 3:37 p.m.
From: Stefan Weil <sw@weilnetz.de>

This was not a bug, but it is not common practice to omit the break statement
from the last case statement before an empty default case.

Any change of the default case would introduce a bug.

This was reported as a warning by splint.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 ui/vnc-enc-hextile-template.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h
index b9f9f5e..a7310e1 100644
--- a/ui/vnc-enc-hextile-template.h
+++ b/ui/vnc-enc-hextile-template.h
@@ -175,6 +175,7 @@  static void CONCAT(send_hextile_tile_, NAME)(VncState *vs,
 	    /* we really don't have to invalidate either the bg or fg
 	       but we've lost the old values.  oh well. */
 	}
+        break;
     default:
 	break;
     }