From patchwork Thu Mar 8 12:48:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 145517 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 4DB9BB6F9D for ; Thu, 8 Mar 2012 23:48:16 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1S5clT-0000e4-I5 for incoming@patchwork.ozlabs.org; Thu, 08 Mar 2012 12:48:15 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1S5clR-0000dy-A9 for fwts-devel@lists.ubuntu.com; Thu, 08 Mar 2012 12:48:13 +0000 Received: from cpc19-craw6-2-0-cust5.croy.cable.virginmedia.com ([77.102.228.6] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S5clR-0003TM-79 for fwts-devel@lists.ubuntu.com; Thu, 08 Mar 2012 12:48:13 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] lib: fwts_klog: remove redundant free() Date: Thu, 8 Mar 2012 12:48:12 +0000 Message-Id: <1331210892-27643-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.9 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Keng-Yu Lin --- src/lib/src/fwts_klog.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/lib/src/fwts_klog.c b/src/lib/src/fwts_klog.c index 39e8183..7b7fb41 100644 --- a/src/lib/src/fwts_klog.c +++ b/src/lib/src/fwts_klog.c @@ -66,10 +66,8 @@ fwts_list *fwts_klog_read(void) if ((len = klogctl(10, NULL, 0)) < 0) return NULL; - if ((buffer = calloc(1, len)) == NULL) { - free(buffer); + if ((buffer = calloc(1, len)) == NULL) return NULL; - } if (klogctl(3, buffer, len) < 0) { free(buffer);