Patchwork [U-Boot] mmc: Fix warning if CONFIG_MMC_TRACE is enabled

login
register
mail settings
Submitter Dirk Behme
Date March 8, 2012, 12:35 p.m.
Message ID <1331210134-11682-1-git-send-email-dirk.behme@de.bosch.com>
Download mbox | patch
Permalink /patch/145515/
State Accepted
Commit 146bec790599717930499a94a10accbbdda746ee
Delegated to: Andy Fleming
Headers show

Comments

Dirk Behme - March 8, 2012, 12:35 p.m.
Fix the warning

mmc.c: In function 'mmc_send_cmd':
mmc.c:87: warning: assignment from incompatible pointer type

in case CONFIG_MMC_TRACE is enabled.

Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
CC: Andy Fleming <afleming@freescale.com>
---
 drivers/mmc/mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Simon Glass - March 31, 2012, 8:12 a.m.
On Thu, Mar 8, 2012 at 4:35 AM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
> Fix the warning
>
> mmc.c: In function 'mmc_send_cmd':
> mmc.c:87: warning: assignment from incompatible pointer type
>
> in case CONFIG_MMC_TRACE is enabled.
>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> CC: Andy Fleming <afleming@freescale.com>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  drivers/mmc/mmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 21665ec..881b5c0 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
>                        for (i = 0; i < 4; i++) {
>                                int j;
>                                printf("\t\t\t\t\t%03d - ", i*4);
> -                               ptr = &cmd->response[i];
> +                               ptr = (u8 *)&cmd->response[i];
>                                ptr += 3;
>                                for (j = 0; j < 4; j++)
>                                        printf("%02X ", *ptr--);
> --
> 1.7.0.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Marek Vasut - March 31, 2012, 6:35 p.m.
Dear Dirk Behme,

> Fix the warning
> 
> mmc.c: In function 'mmc_send_cmd':
> mmc.c:87: warning: assignment from incompatible pointer type
> 
> in case CONFIG_MMC_TRACE is enabled.
> 
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> CC: Andy Fleming <afleming@freescale.com>
> ---

Acked-by: Marek Vasut <marex@denx.de>

>  drivers/mmc/mmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 21665ec..881b5c0 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> struct mmc_data *data) for (i = 0; i < 4; i++) {
>  				int j;
>  				printf("\t\t\t\t\t%03d - ", i*4);
> -				ptr = &cmd->response[i];
> +				ptr = (u8 *)&cmd->response[i];
>  				ptr += 3;
>  				for (j = 0; j < 4; j++)
>  					printf("%02X ", *ptr--);

Best regards,
Marek Vasut
Dirk Behme - April 18, 2012, 10:52 a.m.
On 31.03.2012 20:35, Marek Vasut wrote:
> Dear Dirk Behme,
> 
>> Fix the warning
>>
>> mmc.c: In function 'mmc_send_cmd':
>> mmc.c:87: warning: assignment from incompatible pointer type
>>
>> in case CONFIG_MMC_TRACE is enabled.
>>
>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>> CC: Andy Fleming <afleming@freescale.com>
>> ---
> 
> Acked-by: Marek Vasut <marex@denx.de>
 > Acked-by: Simon Glass <sjg@chromium.org>
> 
>>  drivers/mmc/mmc.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>> index 21665ec..881b5c0 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
>> struct mmc_data *data) for (i = 0; i < 4; i++) {
>>  				int j;
>>  				printf("\t\t\t\t\t%03d - ", i*4);
>> -				ptr = &cmd->response[i];
>> +				ptr = (u8 *)&cmd->response[i];
>>  				ptr += 3;
>>  				for (j = 0; j < 4; j++)
>>  					printf("%02X ", *ptr--);

Who could help to still get this into 2012.04?

Many thanks,

Dirk
Marek Vasut - April 18, 2012, 12:23 p.m.
Dear Dirk Behme,

> On 31.03.2012 20:35, Marek Vasut wrote:
> > Dear Dirk Behme,
> > 
> >> Fix the warning
> >> 
> >> mmc.c: In function 'mmc_send_cmd':
> >> mmc.c:87: warning: assignment from incompatible pointer type
> >> 
> >> in case CONFIG_MMC_TRACE is enabled.
> >> 
> >> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> >> CC: Andy Fleming <afleming@freescale.com>

I'd be glad to see it in ... Andy?

> >> ---
> > 
> > Acked-by: Marek Vasut <marex@denx.de>
> > 
>  > Acked-by: Simon Glass <sjg@chromium.org>
>  > 
> >>  drivers/mmc/mmc.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >> 
> >> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> >> index 21665ec..881b5c0 100644
> >> --- a/drivers/mmc/mmc.c
> >> +++ b/drivers/mmc/mmc.c
> >> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> >> struct mmc_data *data) for (i = 0; i < 4; i++) {
> >> 
> >>  				int j;
> >>  				printf("\t\t\t\t\t%03d - ", i*4);
> >> 
> >> -				ptr = &cmd->response[i];
> >> +				ptr = (u8 *)&cmd->response[i];
> >> 
> >>  				ptr += 3;
> >>  				for (j = 0; j < 4; j++)
> >>  				
> >>  					printf("%02X ", *ptr--);
> 
> Who could help to still get this into 2012.04?
> 
> Many thanks,
> 
> Dirk

Best regards,
Marek Vasut
Wolfgang Denk - April 21, 2012, 3:03 p.m.
Dear Dirk Behme,

In message <1331210134-11682-1-git-send-email-dirk.behme@de.bosch.com> you wrote:
> Fix the warning
> 
> mmc.c: In function 'mmc_send_cmd':
> mmc.c:87: warning: assignment from incompatible pointer type
> 
> in case CONFIG_MMC_TRACE is enabled.
> 
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> CC: Andy Fleming <afleming@freescale.com>
> ---
>  drivers/mmc/mmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 21665ec..881b5c0 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -84,7 +84,7 @@  int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
 			for (i = 0; i < 4; i++) {
 				int j;
 				printf("\t\t\t\t\t%03d - ", i*4);
-				ptr = &cmd->response[i];
+				ptr = (u8 *)&cmd->response[i];
 				ptr += 3;
 				for (j = 0; j < 4; j++)
 					printf("%02X ", *ptr--);