From patchwork Thu Mar 8 09:45:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: xt_log.h: don't use xchg() for simple assignment Date: Wed, 07 Mar 2012 23:45:44 -0000 From: Jan Beulich X-Patchwork-Id: 145475 Message-Id: <4F588DD8020000780007711C@nat28.tlf.novell.com> To: , Cc: At least on ia64 the (bogus) use of xchg() here results in the compiler warning about an unused expression result. As only an assignment is intended here, convert it to such. Signed-off-by: Jan Beulich Acked-by: Eric Dumazet --- include/net/netfilter/xt_log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 3.3-rc6/include/net/netfilter/xt_log.h +++ 3.3-rc6-netfilter-xt_log-no-xchg/include/net/netfilter/xt_log.h @@ -47,7 +47,7 @@ static void sb_close(struct sbuff *m) if (likely(m != &emergency)) kfree(m); else { - xchg(&emergency_ptr, m); + emergency_ptr = m; local_bh_enable(); } }