diff mbox

[2/2] cache-utils.h needs stdint.h for uintptr_t

Message ID 1331168981-13139-2-git-send-email-david@gibson.dropbear.id.au
State New
Headers show

Commit Message

David Gibson March 8, 2012, 1:09 a.m. UTC 
cache-utils.h uses the C99 standard uintptr_t type.  However, that type
comes from stdint.h which is not #included before cache-utils.h in all
configurations.  This patch adds the necessary include to fix this.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 cache-utils.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Stefan Weil March 8, 2012, 6:10 a.m. UTC | #1 
Am 08.03.2012 02:09, schrieb David Gibson:
> cache-utils.h uses the C99 standard uintptr_t type.  However, that type
> comes from stdint.h which is not #included before cache-utils.h in all
> configurations.  This patch adds the necessary include to fix this.
>
> Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
> ---
>   cache-utils.h |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/cache-utils.h b/cache-utils.h
> index 04a6e2e..b0f1786 100644
> --- a/cache-utils.h
> +++ b/cache-utils.h
> @@ -1,6 +1,8 @@
>   #ifndef QEMU_CACHE_UTILS_H
>   #define QEMU_CACHE_UTILS_H
>
> +#include<stdint.h>
> +
>   #if defined(_ARCH_PPC)
>   struct qemu_cache_conf {
>       unsigned long dcache_bsize;

The include statement is only needed for _ARCH_PPC.

See http://patchwork.ozlabs.org/patch/144763/ which
fixes the same issue.

Anthony, Blue, could someone please commit my patch?

Regards,

Stefan W.
David Gibson March 8, 2012, 10:25 a.m. UTC | #2 
On Thu, Mar 08, 2012 at 07:10:38AM +0100, Stefan Weil wrote:
> Am 08.03.2012 02:09, schrieb David Gibson:
> >cache-utils.h uses the C99 standard uintptr_t type.  However, that type
> >comes from stdint.h which is not #included before cache-utils.h in all
> >configurations.  This patch adds the necessary include to fix this.
> >
> >Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
> >---
> >  cache-utils.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> >diff --git a/cache-utils.h b/cache-utils.h
> >index 04a6e2e..b0f1786 100644
> >--- a/cache-utils.h
> >+++ b/cache-utils.h
> >@@ -1,6 +1,8 @@
> >  #ifndef QEMU_CACHE_UTILS_H
> >  #define QEMU_CACHE_UTILS_H
> >
> >+#include<stdint.h>
> >+
> >  #if defined(_ARCH_PPC)
> >  struct qemu_cache_conf {
> >      unsigned long dcache_bsize;
> 
> The include statement is only needed for _ARCH_PPC.
> 
> See http://patchwork.ozlabs.org/patch/144763/ which
> fixes the same issue.

Ok, cool, didn't spot that one.

> Anthony, Blue, could someone please commit my patch?
> 
> Regards,
> 
> Stefan W.
>
diff mbox

Patch

diff --git a/cache-utils.h b/cache-utils.h
index 04a6e2e..b0f1786 100644
--- a/cache-utils.h
+++ b/cache-utils.h
@@ -1,6 +1,8 @@ 
 #ifndef QEMU_CACHE_UTILS_H
 #define QEMU_CACHE_UTILS_H
 
+#include <stdint.h>
+
 #if defined(_ARCH_PPC)
 struct qemu_cache_conf {
     unsigned long dcache_bsize;