Patchwork [GIT,PULL] cpufreq: OMAP updates for v3.4

login
register
mail settings
Submitter Kevin Hilman
Date March 7, 2012, 8:20 p.m.
Message ID <87y5rci2na.fsf@ti.com>
Download mbox
Permalink /patch/145340/
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/cpufreq

Comments

Kevin Hilman - March 7, 2012, 8:20 p.m.
Dave,

Please pull the following OMAP CPUfreq driver changes for v3.4.

Thanks,

Kevin



The following changes since commit b01543dfe67bb1d191998e90d20534dc354de059:

  Linux 3.3-rc4 (2012-02-18 15:53:33 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/cpufreq

for you to fetch changes up to 42daffd2d6c665716d442d518022ecaad17ddf64:

  cpufreq: OMAP: specify range for voltage scaling (2012-03-02 13:55:57 -0800)

----------------------------------------------------------------
Afzal Mohammed (1):
      cpufreq: OMAP: specify range for voltage scaling

Kevin Hilman (1):
      cpufreq: OMAP: scale voltage along with frequency

Russell King (1):
      cpufreq: OMAP driver depends CPUfreq tables

 drivers/cpufreq/Kconfig.arm    |    5 +++
 drivers/cpufreq/Makefile       |    2 +-
 drivers/cpufreq/omap-cpufreq.c |   72 +++++++++++++++++++++++++++++++++++++---
 3 files changed, 73 insertions(+), 6 deletions(-)
Dave Jones - March 7, 2012, 8:30 p.m.
On Wed, Mar 07, 2012 at 12:20:41PM -0800, Kevin Hilman wrote:
 > Dave,
 > 
 > Please pull the following OMAP CPUfreq driver changes for v3.4.

pulled, thanks.

	Dave
Grazvydas Ignotas - March 14, 2012, 4:41 p.m.
On Wed, Mar 7, 2012 at 10:20 PM, Kevin Hilman <khilman@ti.com> wrote:
> Dave,
>
> Please pull the following OMAP CPUfreq driver changes for v3.4.
>
> Thanks,
>
> Kevin
>
>
>
> The following changes since commit b01543dfe67bb1d191998e90d20534dc354de059:
>
>  Linux 3.3-rc4 (2012-02-18 15:53:33 -0800)
>
> are available in the git repository at:
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.4/cpufreq
>
> for you to fetch changes up to 42daffd2d6c665716d442d518022ecaad17ddf64:
>
>  cpufreq: OMAP: specify range for voltage scaling (2012-03-02 13:55:57 -0800)
>
> ----------------------------------------------------------------
> Afzal Mohammed (1):
>      cpufreq: OMAP: specify range for voltage scaling
>
> Kevin Hilman (1):
>      cpufreq: OMAP: scale voltage along with frequency
>
> Russell King (1):
>      cpufreq: OMAP driver depends CPUfreq tables

It seems this one got messed up, it says "default ARCH_OMAP2PLUS"
instead of depends.
Can it be dropped and resent, or do we need a fixup patch?
Dave Jones - March 14, 2012, 4:44 p.m.
On Wed, Mar 14, 2012 at 06:41:51PM +0200, Grazvydas Ignotas wrote:

 > > Afzal Mohammed (1):
 > >      cpufreq: OMAP: specify range for voltage scaling
 > >
 > > Kevin Hilman (1):
 > >      cpufreq: OMAP: scale voltage along with frequency
 > >
 > > Russell King (1):
 > >      cpufreq: OMAP driver depends CPUfreq tables
 > 
 > It seems this one got messed up, it says "default ARCH_OMAP2PLUS"
 > instead of depends.
 > Can it be dropped and resent, or do we need a fixup patch?

Please send a follow-up patch if necessary.

	Dave
Kevin Hilman - March 14, 2012, 5:22 p.m.
Grazvydas Ignotas <notasas@gmail.com> writes:

[...]

>> Russell King (1):
>>      cpufreq: OMAP driver depends CPUfreq tables
>
> It seems this one got messed up, it says "default ARCH_OMAP2PLUS"
> instead of depends.

That was intentional.  What do you think is messed up about it?

It's the same as saying:

     depends on ARCH_OMAP2PLUS
     default y

Kevin
Grazvydas Ignotas - March 14, 2012, 5:38 p.m.
On Wed, Mar 14, 2012 at 7:22 PM, Kevin Hilman <khilman@ti.com> wrote:
> Grazvydas Ignotas <notasas@gmail.com> writes:
>
> [...]
>
>>> Russell King (1):
>>>      cpufreq: OMAP driver depends CPUfreq tables
>>
>> It seems this one got messed up, it says "default ARCH_OMAP2PLUS"
>> instead of depends.
>
> That was intentional.  What do you think is messed up about it?
>
> It's the same as saying:
>
>     depends on ARCH_OMAP2PLUS
>     default y

Hm, somehow I've never encountered this syntax, but it more looks like
it means "default y if ARCH_OMAP2PLUS" instead of that.

Checked this with menuconfig now:
  default ARCH_OMAP2PLUS
resolves to:
  ARCH_HAS_CPUFREQ [=y] && CPU_FREQ [=y] && ARM [=y]

..which might cause build break when OMAP is not selected, and

  depends on ARCH_OMAP2PLUS
  default y
resolves to:
  ARCH_HAS_CPUFREQ [=y] && CPU_FREQ [=y] && ARM [=y] && ARCH_OMAP2PLUS [=y]

..which should be randconfig friendly.
Kevin Hilman - March 15, 2012, 2:25 p.m.
Grazvydas Ignotas <notasas@gmail.com> writes:

> On Wed, Mar 14, 2012 at 7:22 PM, Kevin Hilman <khilman@ti.com> wrote:
>> Grazvydas Ignotas <notasas@gmail.com> writes:
>>
>> [...]
>>
>>>> Russell King (1):
>>>>      cpufreq: OMAP driver depends CPUfreq tables
>>>
>>> It seems this one got messed up, it says "default ARCH_OMAP2PLUS"
>>> instead of depends.
>>
>> That was intentional.  What do you think is messed up about it?
>>
>> It's the same as saying:
>>
>>     depends on ARCH_OMAP2PLUS
>>     default y
>
> Hm, somehow I've never encountered this syntax, but it more looks like
> it means "default y if ARCH_OMAP2PLUS" instead of that.
>
> Checked this with menuconfig now:
>   default ARCH_OMAP2PLUS
> resolves to:
>   ARCH_HAS_CPUFREQ [=y] && CPU_FREQ [=y] && ARM [=y]
>
> ..which might cause build break when OMAP is not selected, and
>
>   depends on ARCH_OMAP2PLUS
>   default y
> resolves to:
>   ARCH_HAS_CPUFREQ [=y] && CPU_FREQ [=y] && ARM [=y] && ARCH_OMAP2PLUS [=y]
>
> ..which should be randconfig friendly.

Yeah, you're right.  Feel free to send a patch using your comments above
to describe that the current form is not randconfig friendly.

Kevin
Kevin Hilman - March 15, 2012, 5 p.m.
Hi Dave,

On 03/07/2012 12:30 PM, Dave Jones wrote:
> On Wed, Mar 07, 2012 at 12:20:41PM -0800, Kevin Hilman wrote:
>   >  Dave,
>   >
>   >  Please pull the following OMAP CPUfreq driver changes for v3.4.
>
> pulled, thanks.

Looks like these got pulled into your fixes branch, but I don't see them 
in linux-next?  Are these on their way upstream?

Kevin