Patchwork [U-Boot,24/25] cleanup/SPEAr: Remove unnecessary parenthesis

login
register
mail settings
Submitter Amit Virdi
Date March 7, 2012, 12:04 p.m.
Message ID <1331121854-20494-25-git-send-email-amit.virdi@st.com>
Download mbox | patch
Permalink /patch/145238/
State Superseded
Delegated to: Stefan Roese
Headers show

Comments

Amit Virdi - March 7, 2012, 12:04 p.m.
In SPEAr configuration files, unnecessary paranthesis are used in some
\#defines. Remove them as they serve no purpose

Signed-off-by: Amit Virdi <amit.virdi@st.com>
---
 include/configs/spear-common.h |    8 ++++----
 include/configs/spear3xx_evb.h |    6 +++---
 include/configs/spear6xx_evb.h |    2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)
Stefan Roese - March 7, 2012, 2:41 p.m.
On Wednesday 07 March 2012 13:04:13 Amit Virdi wrote:
> In SPEAr configuration files, unnecessary paranthesis are used in some
> \#defines. Remove them as they serve no purpose
> 
> Signed-off-by: Amit Virdi <amit.virdi@st.com>

Ahh, I see. I should have scanned all you patches before commenting on these 
cosmetic issues. I assume that you also remove the newly added parentheses 
here? Then I've no objections to apply the earlier patches as well and do the 
cleanup with this patch.

So:

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
Stefan Roese - March 7, 2012, 2:46 p.m.
On Wednesday 07 March 2012 15:41:26 Stefan Roese wrote:
> On Wednesday 07 March 2012 13:04:13 Amit Virdi wrote:
> > In SPEAr configuration files, unnecessary paranthesis are used in some
> > \#defines. Remove them as they serve no purpose
> > 
> > Signed-off-by: Amit Virdi <amit.virdi@st.com>
> 
> Ahh, I see. I should have scanned all you patches before commenting on
> these cosmetic issues. I assume that you also remove the newly added
> parentheses here? Then I've no objections to apply the earlier patches as
> well and do the cleanup with this patch.

This reminds me of the spear headers in arch/arm/include/asm/arch-spear. It 
would be great if you could remove the parentheses here as well.

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
Amit Virdi - March 12, 2012, 1:52 p.m.
On 3/7/2012 8:16 PM, Stefan Roese wrote:
> On Wednesday 07 March 2012 15:41:26 Stefan Roese wrote:
>> On Wednesday 07 March 2012 13:04:13 Amit Virdi wrote:
>>> In SPEAr configuration files, unnecessary paranthesis are used in some
>>> \#defines. Remove them as they serve no purpose
>>>
>>> Signed-off-by: Amit Virdi<amit.virdi@st.com>
>>
>> Ahh, I see. I should have scanned all you patches before commenting on
>> these cosmetic issues. I assume that you also remove the newly added
>> parentheses here? Then I've no objections to apply the earlier patches as
>> well and do the cleanup with this patch.
>
> This reminds me of the spear headers in arch/arm/include/asm/arch-spear. It
> would be great if you could remove the parentheses here as well.
>

Sure! Somehow, I missed this file.

It was my mistake to hold the cleanup patches till the last. Point noted 
for next time ;)

Regards
Amit Virdi

Patch

diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h
index 4fb56ba..fe8d66d 100644
--- a/include/configs/spear-common.h
+++ b/include/configs/spear-common.h
@@ -61,7 +61,7 @@ 
 #define CONFIG_I2C_CHIPADDRESS			0x50
 
 /* Timer, HZ specific defines */
-#define CONFIG_SYS_HZ				(1000)
+#define CONFIG_SYS_HZ				1000
 
 /* Flash configuration */
 #if defined(CONFIG_FLASH_PNOR)
@@ -73,9 +73,9 @@ 
 #if defined(CONFIG_ST_SMI)
 
 #define CONFIG_SYS_MAX_FLASH_BANKS		2
-#define CONFIG_SYS_FLASH_BASE			(0xF8000000)
-#define CONFIG_SYS_CS1_FLASH_BASE		(0xF9000000)
-#define CONFIG_SYS_FLASH_BANK_SIZE		(0x01000000)
+#define CONFIG_SYS_FLASH_BASE			0xF8000000
+#define CONFIG_SYS_CS1_FLASH_BASE		0xF9000000
+#define CONFIG_SYS_FLASH_BANK_SIZE		0x01000000
 #define CONFIG_SYS_FLASH_ADDR_BASE		{CONFIG_SYS_FLASH_BASE, \
 						CONFIG_SYS_CS1_FLASH_BASE}
 #define CONFIG_SYS_MAX_FLASH_SECT		128
diff --git a/include/configs/spear3xx_evb.h b/include/configs/spear3xx_evb.h
index e827a33..5da8115 100644
--- a/include/configs/spear3xx_evb.h
+++ b/include/configs/spear3xx_evb.h
@@ -151,13 +151,13 @@ 
 #define CONFIG_SYS_FSMC_NAND_8BIT
 
 #if defined(CONFIG_SPEAR300)
-#define CONFIG_SYS_NAND_BASE			(0x80000000)
+#define CONFIG_SYS_NAND_BASE			0x80000000
 
 #elif defined(CONFIG_SPEAR310)
-#define CONFIG_SYS_NAND_BASE			(0x40000000)
+#define CONFIG_SYS_NAND_BASE			0x40000000
 
 #elif defined(CONFIG_SPEAR320)
-#define CONFIG_SYS_NAND_BASE			(0x50000000)
+#define CONFIG_SYS_NAND_BASE			0x50000000
 
 #endif
 
diff --git a/include/configs/spear6xx_evb.h b/include/configs/spear6xx_evb.h
index d901ba8..502937a 100644
--- a/include/configs/spear6xx_evb.h
+++ b/include/configs/spear6xx_evb.h
@@ -50,6 +50,6 @@ 
 
 /* NAND flash configuration */
 #define CONFIG_SYS_FSMC_NAND_8BIT
-#define CONFIG_SYS_NAND_BASE			(0xD2000000)
+#define CONFIG_SYS_NAND_BASE			0xD2000000
 
 #endif  /* __CONFIG_H */