Patchwork [U-Boot,12/25] SPEAr: Enable usb device high speed support

login
register
mail settings
Submitter Amit Virdi
Date March 7, 2012, 12:04 p.m.
Message ID <1331121854-20494-13-git-send-email-amit.virdi@st.com>
Download mbox | patch
Permalink /patch/145220/
State Accepted
Commit 507266845025e0ff44892130292d51345596b0ba
Delegated to: Stefan Roese
Headers show

Comments

Amit Virdi - March 7, 2012, 12:04 p.m.
From: Vipin KUMAR <vipin.kumar@st.com>

This patch enables the support for usb high speed device for spear platform SOCs

Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
Signed-off-by: Amit Virdi <amit.virdi@st.com>
---
 include/configs/spear-common.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Stefan Roese - March 7, 2012, 2:07 p.m.
On Wednesday 07 March 2012 13:04:01 Amit Virdi wrote:
> From: Vipin KUMAR <vipin.kumar@st.com>
> 
> This patch enables the support for usb high speed device for spear platform
> SOCs
> 
> Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
> Signed-off-by: Amit Virdi <amit.virdi@st.com>
> ---
>  include/configs/spear-common.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/spear-common.h
> b/include/configs/spear-common.h index 66cf19d..f4980b0 100644
> --- a/include/configs/spear-common.h
> +++ b/include/configs/spear-common.h
> @@ -38,6 +38,7 @@
>  /* USBD driver configuration */
>  #define CONFIG_DW_UDC
>  #define CONFIG_USB_DEVICE
> +#define CONFIG_USBD_HS

This define doesn't seem to be mentioned in the toplevel README file. Please 
add a short description there.

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
Amit Virdi - March 12, 2012, 12:39 p.m.
Hello Stefan,

On 3/7/2012 7:37 PM, Stefan Roese wrote:
> On Wednesday 07 March 2012 13:04:01 Amit Virdi wrote:
>> From: Vipin KUMAR<vipin.kumar@st.com>
>>
>> This patch enables the support for usb high speed device for spear platform
>> SOCs
>>
>> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
>> Signed-off-by: Amit Virdi<amit.virdi@st.com>
>> ---
>>   include/configs/spear-common.h |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/configs/spear-common.h
>> b/include/configs/spear-common.h index 66cf19d..f4980b0 100644
>> --- a/include/configs/spear-common.h
>> +++ b/include/configs/spear-common.h
>> @@ -38,6 +38,7 @@
>>   /* USBD driver configuration */
>>   #define CONFIG_DW_UDC
>>   #define CONFIG_USB_DEVICE
>> +#define CONFIG_USBD_HS
>
> This define doesn't seem to be mentioned in the toplevel README file. Please
> add a short description there.
>

Sure.

Regards
Amit Virdi
Amit Virdi - March 26, 2012, 12:15 p.m.
Hello Stefan,

On 3/12/2012 6:09 PM, Amit Virdi wrote:
> Hello Stefan,
>
> On 3/7/2012 7:37 PM, Stefan Roese wrote:
>> On Wednesday 07 March 2012 13:04:01 Amit Virdi wrote:
>>> From: Vipin KUMAR<vipin.kumar@st.com>
>>>
>>> This patch enables the support for usb high speed device for spear
>>> platform
>>> SOCs
>>>
>>> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
>>> Signed-off-by: Amit Virdi<amit.virdi@st.com>
>>> ---
>>> include/configs/spear-common.h | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/include/configs/spear-common.h
>>> b/include/configs/spear-common.h index 66cf19d..f4980b0 100644
>>> --- a/include/configs/spear-common.h
>>> +++ b/include/configs/spear-common.h
>>> @@ -38,6 +38,7 @@
>>> /* USBD driver configuration */
>>> #define CONFIG_DW_UDC
>>> #define CONFIG_USB_DEVICE
>>> +#define CONFIG_USBD_HS
>>
>> This define doesn't seem to be mentioned in the toplevel README file.
>> Please
>> add a short description there.
>>
>
> Sure.
>

The description of this flag is in the driver patch. Since that patch is 
not applied yet, so you couldn't see the description.

Thanks
Amit Virdi

Patch

diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h
index 66cf19d..f4980b0 100644
--- a/include/configs/spear-common.h
+++ b/include/configs/spear-common.h
@@ -38,6 +38,7 @@ 
 /* USBD driver configuration */
 #define CONFIG_DW_UDC
 #define CONFIG_USB_DEVICE
+#define CONFIG_USBD_HS
 #define CONFIG_USB_TTY
 
 #define CONFIG_USBD_PRODUCT_NAME		"SPEAr SoC"