Patchwork [Precise,no-up] ALSA: hda - add id for Atom Cedar Trail HDMI codec

login
register
mail settings
Submitter David Henningsson
Date March 7, 2012, 8:03 a.m.
Message ID <1331107387-2886-1-git-send-email-david.henningsson@canonical.com>
Download mbox | patch
Permalink /patch/145163/
State New
Headers show

Comments

David Henningsson - March 7, 2012, 8:03 a.m.
From: Wu Fengguang <fengguang.wu@intel.com>

[the order sorted by tiwai]

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

(cherry picked from commit 6edc59e602b36cd3c95a426ef6e8cad0344af8c7,
 git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---

(Not sure why this wasn't cc:ed stable@kernel.org or even 3.3, but maybe
there isn't enough of the graphics stack present in upstream kernels anyway.)

 sound/pci/hda/patch_hdmi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Andy Whitcroft - March 7, 2012, 8:25 a.m.
On Wed, Mar 07, 2012 at 09:03:07AM +0100, David Henningsson wrote:
> From: Wu Fengguang <fengguang.wu@intel.com>
> 
> [the order sorted by tiwai]
> 
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> (cherry picked from commit 6edc59e602b36cd3c95a426ef6e8cad0344af8c7,
>  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
> 
> (Not sure why this wasn't cc:ed stable@kernel.org or even 3.3, but maybe
> there isn't enough of the graphics stack present in upstream kernels anyway.)
> 
>  sound/pci/hda/patch_hdmi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index d8d4a8d..ade2d2f 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1913,6 +1913,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>  { .id = 0x80862804, .name = "IbexPeak HDMI",	.patch = patch_generic_hdmi },
>  { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
>  { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
> +{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
>  { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
>  {} /* terminator */
>  };
> @@ -1959,6 +1960,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862803");
>  MODULE_ALIAS("snd-hda-codec-id:80862804");
>  MODULE_ALIAS("snd-hda-codec-id:80862805");
>  MODULE_ALIAS("snd-hda-codec-id:80862806");
> +MODULE_ALIAS("snd-hda-codec-id:80862880");
>  MODULE_ALIAS("snd-hda-codec-id:808629fb");
>  
>  MODULE_LICENSE("GPL");

Looks simple enough.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Tim Gardner - March 7, 2012, 2:01 p.m.
On 03/07/2012 01:03 AM, David Henningsson wrote:
> From: Wu Fengguang<fengguang.wu@intel.com>
>
> [the order sorted by tiwai]
>
> Signed-off-by: Wu Fengguang<fengguang.wu@intel.com>
> Signed-off-by: Takashi Iwai<tiwai@suse.de>
>
> (cherry picked from commit 6edc59e602b36cd3c95a426ef6e8cad0344af8c7,
>   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: David Henningsson<david.henningsson@canonical.com>
> ---
>
> (Not sure why this wasn't cc:ed stable@kernel.org or even 3.3, but maybe
> there isn't enough of the graphics stack present in upstream kernels anyway.)
>
>   sound/pci/hda/patch_hdmi.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index d8d4a8d..ade2d2f 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -1913,6 +1913,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
>   { .id = 0x80862804, .name = "IbexPeak HDMI",	.patch = patch_generic_hdmi },
>   { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
>   { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
> +{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
>   { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
>   {} /* terminator */
>   };
> @@ -1959,6 +1960,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862803");
>   MODULE_ALIAS("snd-hda-codec-id:80862804");
>   MODULE_ALIAS("snd-hda-codec-id:80862805");
>   MODULE_ALIAS("snd-hda-codec-id:80862806");
> +MODULE_ALIAS("snd-hda-codec-id:80862880");
>   MODULE_ALIAS("snd-hda-codec-id:808629fb");
>
>   MODULE_LICENSE("GPL");
Chase Douglas - March 7, 2012, 5:16 p.m.
On 03/07/2012 12:03 AM, David Henningsson wrote:
> From: Wu Fengguang<fengguang.wu@intel.com>
>
> [the order sorted by tiwai]
>
> Signed-off-by: Wu Fengguang<fengguang.wu@intel.com>
> Signed-off-by: Takashi Iwai<tiwai@suse.de>
>
> (cherry picked from commit 6edc59e602b36cd3c95a426ef6e8cad0344af8c7,
>   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: David Henningsson<david.henningsson@canonical.com>
> ---
>
> (Not sure why this wasn't cc:ed stable@kernel.org or even 3.3, but maybe
> there isn't enough of the graphics stack present in upstream kernels anyway.)

Sometimes (oftentimes, really), developers and maintainers forget to add 
the Cc: stable@vger.kernel.org tag, and then no one else bothers with it.

In these cases, I usually send the patch manually to 
stable@vger.kernel.org. I'd suggest doing it for this commit, it seems 
to follow the guidelines for stable.

-- Chase
Tim Gardner - March 7, 2012, 5:29 p.m.
On 03/07/2012 10:16 AM, Chase Douglas wrote:
> On 03/07/2012 12:03 AM, David Henningsson wrote:
>> From: Wu Fengguang<fengguang.wu@intel.com>
>>
>> [the order sorted by tiwai]
>>
>> Signed-off-by: Wu Fengguang<fengguang.wu@intel.com>
>> Signed-off-by: Takashi Iwai<tiwai@suse.de>
>>
>> (cherry picked from commit 6edc59e602b36cd3c95a426ef6e8cad0344af8c7,
>> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
>> Signed-off-by: David Henningsson<david.henningsson@canonical.com>
>> ---
>>
>> (Not sure why this wasn't cc:ed stable@kernel.org or even 3.3, but maybe
>> there isn't enough of the graphics stack present in upstream kernels
>> anyway.)
>
> Sometimes (oftentimes, really), developers and maintainers forget to add
> the Cc: stable@vger.kernel.org tag, and then no one else bothers with it.
>
> In these cases, I usually send the patch manually to
> stable@vger.kernel.org. I'd suggest doing it for this commit, it seems
> to follow the guidelines for stable.
>
> -- Chase
>

But not until its been merged into Linus' tree.

Patch

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index d8d4a8d..ade2d2f 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -1913,6 +1913,7 @@  static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x80862804, .name = "IbexPeak HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862805, .name = "CougarPoint HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862806, .name = "PantherPoint HDMI", .patch = patch_generic_hdmi },
+{ .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
 {} /* terminator */
 };
@@ -1959,6 +1960,7 @@  MODULE_ALIAS("snd-hda-codec-id:80862803");
 MODULE_ALIAS("snd-hda-codec-id:80862804");
 MODULE_ALIAS("snd-hda-codec-id:80862805");
 MODULE_ALIAS("snd-hda-codec-id:80862806");
+MODULE_ALIAS("snd-hda-codec-id:80862880");
 MODULE_ALIAS("snd-hda-codec-id:808629fb");
 
 MODULE_LICENSE("GPL");