Patchwork [1/9] pci_ids: Add device ID for IBM PCI-X bridge

login
register
mail settings
Submitter chenhui zhao
Date March 6, 2012, 9:05 a.m.
Message ID <1331024707-15891-1-git-send-email-chenhui.zhao@freescale.com>
Download mbox | patch
Permalink /patch/144871/
State Superseded
Delegated to: Kumar Gala
Headers show

Comments

chenhui zhao - March 6, 2012, 9:05 a.m.
Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
---
 include/linux/pci_ids.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Kumar Gala - March 6, 2012, 12:14 p.m.
On Mar 6, 2012, at 3:05 AM, Zhao Chenhui wrote:

> Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> ---
> include/linux/pci_ids.h |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Just merge this with the 2nd patch that actually uses the ID.

- k
Greg KH - March 6, 2012, 2:32 p.m.
On Tue, Mar 06, 2012 at 05:05:07PM +0800, Zhao Chenhui wrote:
> Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> ---
>  include/linux/pci_ids.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 31d77af..8f026c0 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -484,6 +484,7 @@
>  #define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM	0x0251
>  #define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM_PCIE 0x0361
>  #define PCI_DEVICE_ID_IBM_ICOM_FOUR_PORT_MODEL	0x252
> +#define PCI_DEVICE_ID_IBM_PCIX_BRIDGE	0x01a7

Did you read the comment at the top of this file?
Zhao Chenhui - March 7, 2012, 8:40 a.m.
> On Mar 6, 2012, at 3:05 AM, Zhao Chenhui wrote:
> 
> > Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> > ---
> > include/linux/pci_ids.h |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Just merge this with the 2nd patch that actually uses the ID.
> 
> - k

Ok. I put it in the file mpc85xx_cds.c.

-Chenhui
Zang Roy-R61911 - March 8, 2012, 7:55 a.m.
> -----Original Message-----
> From: linuxppc-dev-bounces+tie-fei.zang=freescale.com@lists.ozlabs.org
> [mailto:linuxppc-dev-bounces+tie-fei.zang=freescale.com@lists.ozlabs.org]
> On Behalf Of Kumar Gala
> Sent: Tuesday, March 06, 2012 20:14 PM
> To: Zhao Chenhui-B35336
> Cc: linux-pci@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH 1/9] pci_ids: Add device ID for IBM PCI-X bridge
> 
> 
> On Mar 6, 2012, at 3:05 AM, Zhao Chenhui wrote:
> 
> > Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> > ---
> > include/linux/pci_ids.h |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Just merge this with the 2nd patch that actually uses the ID.
Why does this necessary?
I'd prefer using a separate patch for the PCI ID.
Roy

Patch

diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 31d77af..8f026c0 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -484,6 +484,7 @@ 
 #define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM	0x0251
 #define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM_PCIE 0x0361
 #define PCI_DEVICE_ID_IBM_ICOM_FOUR_PORT_MODEL	0x252
+#define PCI_DEVICE_ID_IBM_PCIX_BRIDGE	0x01a7
 
 #define PCI_SUBVENDOR_ID_IBM		0x1014
 #define PCI_SUBDEVICE_ID_IBM_SATURN_SERIAL_ONE_PORT	0x03d4