From patchwork Mon Mar 5 17:07:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 144718 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D6816B6FA2 for ; Tue, 6 Mar 2012 04:08:14 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1331572095; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Received-SPF:Received:Received:Received:Received:From:To:Cc: Subject:References:Date:In-Reply-To:Message-ID:User-Agent: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=rJicyVvfyjEFcPVXtg4NxR6oDXg=; b=APqjfAC6A7yM5Y5 tM6Sfyjt+4AJFNW+r4cft5obXqNjNNV2gQeO/udcx0+9lssN7pwJi1qWGtrJIf1k oVKb1nuk/o9aSh31PhKXuTKAexr0JS9f4CzBLmko4YEUTgkKyQpsYJFFpxSeDO+I ZC0bQnjgHASx9HNg5nL4XTch4EVo= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received-SPF:Authentication-Results:Received:Received:Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:X-Gm-Message-State:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=lICuqeiNPXgvI9gsMtVt0JUKHavvfV/VveR5HYN51L6CxmB/u2tzZhAJPBOxxd mmxU7sWIj2hDRIpsbKta+Q06u81geo1ROw+fbajhQyBJ+USDXyQ6OJO1u3AXRLTB WItUluuwiiP9hdjjTi3yEwPGzwbhkBG46o6jq6Pv83u3Y=; Received: (qmail 13846 invoked by alias); 5 Mar 2012 17:07:59 -0000 Received: (qmail 13834 invoked by uid 22791); 5 Mar 2012 17:07:56 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, TW_ZJ, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from mail-pz0-f48.google.com (HELO mail-pz0-f48.google.com) (209.85.210.48) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Mar 2012 17:07:43 +0000 Received: by dadp13 with SMTP id p13so4109747dad.21 for ; Mon, 05 Mar 2012 09:07:43 -0800 (PST) Received-SPF: pass (google.com: domain of iant@google.com designates 10.68.219.130 as permitted sender) client-ip=10.68.219.130; Authentication-Results: mr.google.com; spf=pass (google.com: domain of iant@google.com designates 10.68.219.130 as permitted sender) smtp.mail=iant@google.com; dkim=pass header.i=iant@google.com Received: from mr.google.com ([10.68.219.130]) by 10.68.219.130 with SMTP id po2mr51274155pbc.140.1330967263122 (num_hops = 1); Mon, 05 Mar 2012 09:07:43 -0800 (PST) Received: by 10.68.219.130 with SMTP id po2mr43900444pbc.140.1330967263083; Mon, 05 Mar 2012 09:07:43 -0800 (PST) Received: by 10.68.219.130 with SMTP id po2mr43900422pbc.140.1330967263009; Mon, 05 Mar 2012 09:07:43 -0800 (PST) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id x1sm13772593pbp.50.2012.03.05.09.07.41 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 05 Mar 2012 09:07:41 -0800 (PST) From: Ian Lance Taylor To: Uros Bizjak Cc: gcc-patches@gcc.gnu.org Subject: Re: libgo patch committed: Update to weekly.2012-02-22 release References: Date: Mon, 05 Mar 2012 09:07:39 -0800 In-Reply-To: (Uros Bizjak's message of "Sun, 4 Mar 2012 22:11:00 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQmBwpITPRDOC9UJFotB8lOXRiotwBX/83BburrJe1VbHOy2LkmktuLUzjcy91zrVlyw3jC4NH6OWxoCpT8j3M6efatmTcy/nf6s0/vDKg/t3OoY1s9Zsnwho5a8r7uzTpTnxuAL/uZfjqNjLSDrD7B/cqhoK8pKHhTPVzZXwEIn8M60nhg= X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Uros Bizjak writes: > It looks that this patch introduced: > > /home/uros/gcc-build-go/x86_64-unknown-linux-gnu/32/libgo/.libs/libgo.so: > undefined reference to `libgo_runtime.runtime.Callers' > collect2: error: ld returned 1 exit status > > All libgo tests fail due to this undefined reference. I guess I'm not seeing it because your system is defaulting to -Wl,-z,now. Fixed with this patch. Sorry about that. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 2f1b1ab1b4d9 libgo/runtime/go-callers.c --- a/libgo/runtime/go-callers.c Sun Mar 04 22:37:34 2012 -0800 +++ b/libgo/runtime/go-callers.c Mon Mar 05 09:06:45 2012 -0800 @@ -55,3 +55,12 @@ _Unwind_Backtrace (backtrace, &arg); return arg.index; } + +int Callers (int, struct __go_open_array) + __asm__ ("libgo_runtime.runtime.Callers"); + +int +Callers (int skip, struct __go_open_array pc) +{ + return runtime_callers (skip, (uintptr *) pc.__values, pc.__count); +}