Patchwork [11/11] ext4: try to deprecate noacl and noxattr_user mount options

login
register
mail settings
Submitter Theodore Ts'o
Date March 5, 2012, 3:08 a.m.
Message ID <1330916905-5976-11-git-send-email-tytso@mit.edu>
Download mbox | patch
Permalink /patch/144574/
State Accepted
Headers show

Comments

Theodore Ts'o - March 5, 2012, 3:08 a.m.
No other file system allows ACL's and extended attributes to be
enabled or disabled via a mount option.  So let's try to deprecate
these options from ext4.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 fs/ext4/super.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 960681f..25b1f03 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1443,6 +1443,10 @@  static int handle_mount_opt(struct super_block *sb, char *opt, int token,
 	if (args->from && match_int(args, &arg))
 		return -1;
 	switch (token) {
+	case Opt_noacl:
+	case Opt_nouser_xattr:
+		ext4_msg(sb, KERN_WARNING, deprecated_msg, opt, "3.5");
+		break;
 	case Opt_sb:
 		return 1;	/* handled by get_sb_block() */
 	case Opt_removed: