diff mbox

[U-Boot,V2,1/3] i.MX6: define CACHELINE_SIZE

Message ID 1330897659-9049-2-git-send-email-eric.nelson@boundarydevices.com
State Deferred
Delegated to: Stefano Babic
Headers show

Commit Message

Eric Nelson March 4, 2012, 9:47 p.m. UTC 
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Marek Vasut <marex@denx.de>

---
 arch/arm/include/asm/arch-mx6/imx-regs.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Eric Nelson March 13, 2012, 1:08 a.m. UTC | #1 
On 03/04/2012 02:47 PM, Eric Nelson wrote:
> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
> Acked-by: Marek Vasut<marex@denx.de>
>
> ---
>   arch/arm/include/asm/arch-mx6/imx-regs.h |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h b/arch/arm/include/asm/arch-mx6/imx-regs.h
> index 6a200bb..3e5c4c2 100644
> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
> @@ -19,6 +19,8 @@
>   #ifndef __ASM_ARCH_MX6_IMX_REGS_H__
>   #define __ASM_ARCH_MX6_IMX_REGS_H__
>
> +#define CONFIG_SYS_CACHELINE_SIZE	32
> +
>   #define ROMCP_ARB_BASE_ADDR             0x00000000
>   #define ROMCP_ARB_END_ADDR              0x000FFFFF
>   #define CAAM_ARB_BASE_ADDR              0x00100000

Hi Stefano,

Any word on this patch?

Please advise,


Eric
Stefano Babic March 13, 2012, 8:20 a.m. UTC | #2 
On 13/03/2012 02:08, Eric Nelson wrote:
> On 03/04/2012 02:47 PM, Eric Nelson wrote:
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> Acked-by: Marek Vasut<marex@denx.de>
>>
>> ---
>>   arch/arm/include/asm/arch-mx6/imx-regs.h |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
>> b/arch/arm/include/asm/arch-mx6/imx-regs.h
>> index 6a200bb..3e5c4c2 100644
>> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
>> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
>> @@ -19,6 +19,8 @@
>>   #ifndef __ASM_ARCH_MX6_IMX_REGS_H__
>>   #define __ASM_ARCH_MX6_IMX_REGS_H__
>>
>> +#define CONFIG_SYS_CACHELINE_SIZE    32
>> +
>>   #define ROMCP_ARB_BASE_ADDR             0x00000000
>>   #define ROMCP_ARB_END_ADDR              0x000FFFFF
>>   #define CAAM_ARB_BASE_ADDR              0x00100000
> 
> Hi Stefano,
> 
> Any word on this patch?

No, but the patch is at the moment not useful until the FEC driver works
with enabled cache.

Best regards,
Stefano Babic
Eric Nelson March 13, 2012, 1:29 p.m. UTC | #3 
On 03/13/2012 01:20 AM, Stefano Babic wrote:
> On 13/03/2012 02:08, Eric Nelson wrote:
>> On 03/04/2012 02:47 PM, Eric Nelson wrote:
>>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>>> Acked-by: Marek Vasut<marex@denx.de>
>>>
>>> ---
>>>    arch/arm/include/asm/arch-mx6/imx-regs.h |    2 ++
>>>    1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
>>> b/arch/arm/include/asm/arch-mx6/imx-regs.h
>>> index 6a200bb..3e5c4c2 100644
>>> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
>>> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
>>> @@ -19,6 +19,8 @@
>>>    #ifndef __ASM_ARCH_MX6_IMX_REGS_H__
>>>    #define __ASM_ARCH_MX6_IMX_REGS_H__
>>>
>>> +#define CONFIG_SYS_CACHELINE_SIZE    32
>>> +
>>>    #define ROMCP_ARB_BASE_ADDR             0x00000000
>>>    #define ROMCP_ARB_END_ADDR              0x000FFFFF
>>>    #define CAAM_ARB_BASE_ADDR              0x00100000
>>
>> Hi Stefano,
>>
>> Any word on this patch?
>
> No, but the patch is at the moment not useful until the FEC driver works
> with enabled cache.
>
> Best regards,
> Stefano Babic
>
Hi Stefano,

This is used by arch/arm/include/asm/cache.h to set ARCH_DMA_MINALIGN
so any driver or subsystem that uses ALLOC_CACHE_ALIGN_BUFFER will
be affected.

On that topic, it appears that this patch to support cache in the
SD card driver was overlooked:

	http://lists.denx.de/pipermail/u-boot/2012-March/119312.html

Regards,


Eric
Stefano Babic March 19, 2012, 3:38 p.m. UTC | #4 
On 13/03/2012 02:08, Eric Nelson wrote:
> On 03/04/2012 02:47 PM, Eric Nelson wrote:
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> Acked-by: Marek Vasut<marex@denx.de>
>>
>> ---
>>   arch/arm/include/asm/arch-mx6/imx-regs.h |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
>> b/arch/arm/include/asm/arch-mx6/imx-regs.h
>> index 6a200bb..3e5c4c2 100644
>> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
>> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
>> @@ -19,6 +19,8 @@
>>   #ifndef __ASM_ARCH_MX6_IMX_REGS_H__
>>   #define __ASM_ARCH_MX6_IMX_REGS_H__
>>
>> +#define CONFIG_SYS_CACHELINE_SIZE    32
>> +
>>   #define ROMCP_ARB_BASE_ADDR             0x00000000
>>   #define ROMCP_ARB_END_ADDR              0x000FFFFF
>>   #define CAAM_ARB_BASE_ADDR              0x00100000
> 

Applied to u-boot-imx, next branch.

Best regards,
Stefano Babic
Stefano Babic April 1, 2012, 1:28 p.m. UTC | #5 
On 13/03/2012 02:08, Eric Nelson wrote:
> On 03/04/2012 02:47 PM, Eric Nelson wrote:
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> Acked-by: Marek Vasut<marex@denx.de>
>>
>> ---


Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h b/arch/arm/include/asm/arch-mx6/imx-regs.h
index 6a200bb..3e5c4c2 100644
--- a/arch/arm/include/asm/arch-mx6/imx-regs.h
+++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
@@ -19,6 +19,8 @@ 
 #ifndef __ASM_ARCH_MX6_IMX_REGS_H__
 #define __ASM_ARCH_MX6_IMX_REGS_H__
 
+#define CONFIG_SYS_CACHELINE_SIZE	32
+
 #define ROMCP_ARB_BASE_ADDR             0x00000000
 #define ROMCP_ARB_END_ADDR              0x000FFFFF
 #define CAAM_ARB_BASE_ADDR              0x00100000