[U-Boot] Bug in cfb_console driver

Submitted by Pali Rohár on March 4, 2012, 9:12 p.m.

Details

Message ID 1815857.Df8ir0xyPp@pali
State Not Applicable
Delegated to: Anatolij Gustschin
Headers show

Commit Message

Pali Rohár March 4, 2012, 9:12 p.m.
On Saturday 14 January 2012 04:32:04 Pali Rohár wrote:
> Hello,
> 
> commit 03d31fcf4c37d90a00e66f06b38742960139f090 break video framebuffer
> output on Nokia N900. After this commit is video output garbaged and not
> readable on display. Problem is in function video_invertchar() - when I
> commented it, video output is OK, but without cursor. Problem is only on
> real N900 device, not in qemu.

This is simple preview how to fix output on N900 display:


But I think that function video_invertchar which is needed for rendering cursor should be fixed properly.

Can somebody check if current implementaion of function video_invertchar is correct? I do not properly understand that code, so I cannot debug it.

Comments

Anatolij Gustschin March 5, 2012, 10:16 a.m.
Hi,

On Sun, 04 Mar 2012 22:12:20 +0100
Pali Rohár <pali.rohar@gmail.com> wrote:

> On Saturday 14 January 2012 04:32:04 Pali Rohár wrote:
> > Hello,
> > 
> > commit 03d31fcf4c37d90a00e66f06b38742960139f090 break video framebuffer
> > output on Nokia N900. After this commit is video output garbaged and not
> > readable on display. Problem is in function video_invertchar() - when I
> > commented it, video output is OK, but without cursor. Problem is only on
> > real N900 device, not in qemu.
> 
> This is simple preview how to fix output on N900 display:
...
> But I think that function video_invertchar which is needed for rendering
> cursor should be fixed properly.
> 
> Can somebody check if current implementaion of function video_invertchar
> is correct? I do not properly understand that code, so I cannot debug it.

I hoped that Gabe will look at the issue. Gabe, any idea what could be
wrong here? I'll also look at it later today.

Thanks,
Anatolij
Pali Rohár March 5, 2012, 10:42 a.m.
On Monday 05 March 2012 11:16:53 Anatolij Gustschin wrote:
> Hi,
> 
> On Sun, 04 Mar 2012 22:12:20 +0100
> 
> Pali Rohár <pali.rohar@gmail.com> wrote:
> > On Saturday 14 January 2012 04:32:04 Pali Rohár wrote:
> > > Hello,
> > > 
> > > commit 03d31fcf4c37d90a00e66f06b38742960139f090 break video framebuffer
> > > output on Nokia N900. After this commit is video output garbaged and not
> > > readable on display. Problem is in function video_invertchar() - when I
> > > commented it, video output is OK, but without cursor. Problem is only on
> > > real N900 device, not in qemu.
> > 
> > This is simple preview how to fix output on N900 display:
> ...
> 
> > But I think that function video_invertchar which is needed for rendering
> > cursor should be fixed properly.
> > 
> > Can somebody check if current implementaion of function video_invertchar
> > is correct? I do not properly understand that code, so I cannot debug it.
> 
> I hoped that Gabe will look at the issue. Gabe, any idea what could be
> wrong here? I'll also look at it later today.
> 
> Thanks,
> Anatolij

Hi, thanks. If you need some more info write me.

Patch hide | download patch | download mbox

diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index eb013b8..7cd3cc5 100644
--- a/drivers/video/cfb_console.c
+++ b/drivers/video/cfb_console.c
@@ -624,6 +624,7 @@  static void video_set_cursor(void)
 
 static void video_invertchar(int xx, int yy)
 {
+	/* Disabled on RX51
 	int firstx = xx * VIDEO_PIXEL_SIZE;
 	int lastx = (xx + VIDEO_FONT_WIDTH) * VIDEO_PIXEL_SIZE;
 	int firsty = yy * VIDEO_LINE_LEN;
@@ -635,6 +636,7 @@  static void video_invertchar(int xx, int yy)
 			*dest = ~*dest;
 		}
 	}
+	*/
 }
 
 void console_cursor(int state)