Patchwork [RFC] remove -W from build process

login
register
mail settings
Submitter Sebastian Siewior
Date Dec. 17, 2008, 10:19 a.m.
Message ID <20081217101924.GB4999@www.tglx.de>
Download mbox | patch
Permalink /patch/14450/
State RFC
Headers show

Comments

Sebastian Siewior - Dec. 17, 2008, 10:19 a.m.
I didn't really figured what exactly goes wrong but if I compile with
CFLAGS unset then the compile process goes like this:
| gcc -O2 -Werror -Wall -Iinclude -Isrc -I../../include src/ubiupdatevol.c -c -o ubiupdatevol.o

Once I set the enviroment CFLAGS to "-g -O2" I also get
"-Wall -Wall -Wwrite-strings -W":
| gcc -g -O2 -Wall -Wall -Wwrite-strings -W -Werror -Wall -Iinclude -Isrc -I../../include src/ubiupdatevol.c -c -o ubiupdatevol.o
|cc1: warnings being treated as errors
|src/ubiupdatevol.c: In function 'truncate_volume':
|src/ubiupdatevol.c:179: error: comparison between signed and unsigned
|src/ubiupdatevol.c:183: error: comparison between signed and unsigned
....

and it aborts. I tried to cleanup the signed and unsigned thing but it is
a long a way. So I guess it may be the best to just disable -Wextra for
now.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
Would it be possible to use autotools for a clean build environment?

 ubi-utils/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Mike Frysinger - Dec. 17, 2008, 10:29 a.m.
On Wed, Dec 17, 2008 at 05:19, Sebastian Andrzej Siewior wrote:
> Would it be possible to use autotools for a clean build environment?

it would make no difference here
-mike
Sebastian Siewior - Dec. 17, 2008, 11:16 a.m.
Mike Frysinger wrote:
> On Wed, Dec 17, 2008 at 05:19, Sebastian Andrzej Siewior wrote:
>> Would it be possible to use autotools for a clean build environment?
> 
> it would make no difference here
It won't fix compile error, right. I thing it could be easier the handle 
CFLAGS, cross builds, install, build dir, rebuilds, ...
Alternatively one could clean up the current make scripts but I thing it 
would be easier to handle this with auto tools.

> -mike

Sebastian
Mike Frysinger - Dec. 17, 2008, 11:17 a.m.
On Wed, Dec 17, 2008 at 06:16, Sebastian Andrzej Siewior wrote:
> Mike Frysinger wrote:
>> On Wed, Dec 17, 2008 at 05:19, Sebastian Andrzej Siewior wrote:
>>> Would it be possible to use autotools for a clean build environment?
>>
>> it would make no difference here
>
> It won't fix compile error, right. I thing it could be easier the handle
> CFLAGS, cross builds, install, build dir, rebuilds, ...
> Alternatively one could clean up the current make scripts but I thing it
> would be easier to handle this with auto tools.

ive already posted a patch to cleanup the build system and it should
address every issue you highlighted here ...
-mike
Sebastian Siewior - Dec. 17, 2008, 12:05 p.m.
Mike Frysinger wrote:
> On Wed, Dec 17, 2008 at 06:16, Sebastian Andrzej Siewior wrote:
>> Mike Frysinger wrote:
>>> On Wed, Dec 17, 2008 at 05:19, Sebastian Andrzej Siewior wrote:
>>>> Would it be possible to use autotools for a clean build environment?
>>> it would make no difference here
>> It won't fix compile error, right. I thing it could be easier the handle
>> CFLAGS, cross builds, install, build dir, rebuilds, ...
>> Alternatively one could clean up the current make scripts but I thing it
>> would be easier to handle this with auto tools.
> 
> ive already posted a patch to cleanup the build system and it should
> address every issue you highlighted here ...

Cool. I thing you refer to "unify all common build system parts". It looks 
promising and smaller than my attempt.

> -mike

Sebastian

Patch

diff --git a/ubi-utils/Makefile b/ubi-utils/Makefile
index 63058e1..67e9f6a 100644
--- a/ubi-utils/Makefile
+++ b/ubi-utils/Makefile
@@ -10,7 +10,7 @@  INCLUDEDIR=/usr/include
 
 CC := $(CROSS)gcc
 CFLAGS ?= -O2 -g -Werror
-CFLAGS += -Wall -Wwrite-strings -W
+CFLAGS += -Wall -Wwrite-strings
 CPPFLAGS += -I./inc -I./src -I$(KERNELHDR) \
 	-std=gnu99 -DPACKAGE_VERSION=\"1.0\"