Patchwork [U-Boot] USB: Squash warning in usb_hub.c

login
register
mail settings
Submitter Marek Vasut
Date March 3, 2012, 3:07 p.m.
Message ID <1330787221-22360-1-git-send-email-marex@denx.de>
Download mbox | patch
Permalink /patch/144427/
State Accepted
Delegated to: Marek Vasut
Headers show

Comments

Marek Vasut - March 3, 2012, 3:07 p.m.
usb_hub.c:79:12: warning: ‘usb_clear_hub_feature’ defined but not used [-Wunused-function]

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
---
 common/usb_hub.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
Wolfgang Denk - March 3, 2012, 3:28 p.m.
Dear Marek Vasut,

In message <1330787221-22360-1-git-send-email-marex@denx.de> you wrote:
> usb_hub.c:79:12: warning: ‘usb_clear_hub_feature’ defined but not used [-Wunused-function]
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>

This warning was introduced here:

	40a5635d47e82b54af35888e5f357a6e58ad0937 is the first bad commit
	commit 40a5635d47e82b54af35888e5f357a6e58ad0937
	Author: Marek Vasut <marek.vasut@gmail.com>
	Date:   Mon Feb 13 18:58:16 2012 +0000

	    USB: Staticize internal functions
	    
	    Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
	    Cc: Remy Bohmer <linux@bohmer.net>
	    Acked-by: Mike Frysinger <vapier@gentoo.org>

I will squash this patch with the original commit to avoid the warning
in mainline.

Best regards,

Wolfgang Denk

Patch

diff --git a/common/usb_hub.c b/common/usb_hub.c
index 08cee54..84d0d3f 100644
--- a/common/usb_hub.c
+++ b/common/usb_hub.c
@@ -76,13 +76,6 @@  static int usb_get_hub_descriptor(struct usb_device *dev, void *data, int size)
 		USB_DT_HUB << 8, 0, data, size, USB_CNTL_TIMEOUT);
 }
 
-static int usb_clear_hub_feature(struct usb_device *dev, int feature)
-{
-	return usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
-				USB_REQ_CLEAR_FEATURE, USB_RT_HUB, feature,
-				0, NULL, 0, USB_CNTL_TIMEOUT);
-}
-
 static int usb_clear_port_feature(struct usb_device *dev, int port, int feature)
 {
 	return usb_control_msg(dev, usb_sndctrlpipe(dev, 0),