Patchwork [4.8,Fortran] PR 48820 - Support TYPE(*) of TS29113

login
register
mail settings
Submitter Tobias Burnus
Date March 3, 2012, 2:17 p.m.
Message ID <4F5227F4.3050809@net-b.de>
Download mbox | patch
Permalink /patch/144424/
State New
Headers show

Comments

Tobias Burnus - March 3, 2012, 2:17 p.m.
Tobias Burnus wrote:
> thanks for the review.
>
> Paul Richard Thomas wrote:
> [...]

Something is odd. The test case didn't regtest, but I could swear that 
it did so yesterday.

_1.f90: That was correctly failing because one cannot pass an 
assumed-size array to an assumed-shape array.

_4.f90: Somehow, the line has changed.

_3.f90: Besides some more obvious issues, there is:

"fourteen" is really odd: Depending on the position of that subroutine 
in file, I get an error or not. I think one should try to better 
understand why that happens.

Tobias

Patch

Index: gcc/testsuite/ChangeLog
===================================================================
--- gcc/testsuite/ChangeLog	(Revision 184855)
+++ gcc/testsuite/ChangeLog	(Arbeitskopie)
@@ -1,6 +1,13 @@ 
 2012-03-03  Tobias Burnus  <burnus@net-b.de>
 
 	PR fortran/48820
+	* gfortran.dg/assumed_type_1.f90: Correct dg-error.
+	* gfortran.dg/assumed_type_3.f90: Correct dg-error.
+	* gfortran.dg/assumed_type_4.f90: Correct dg-error.
+
+2012-03-03  Tobias Burnus  <burnus@net-b.de>
+
+	PR fortran/48820
 	* gfortran.dg/assumed_type_1.f90: New.
 	* gfortran.dg/assumed_type_2.f90: New.
 	* gfortran.dg/assumed_type_3.f90: New.
Index: gcc/testsuite/gfortran.dg/assumed_type_1.f90
===================================================================
--- gcc/testsuite/gfortran.dg/assumed_type_1.f90	(Revision 184855)
+++ gcc/testsuite/gfortran.dg/assumed_type_1.f90	(Arbeitskopie)
@@ -49,7 +49,6 @@  use mpi_interface
 contains
     subroutine foo(x)
     type(*):: x(*)
-    call MPI_Send(x, 1, 1,1,1,j,i)
     call MPI_Send2(x, 1, 1,1,1,j,i)
   end
 end
Index: gcc/testsuite/gfortran.dg/assumed_type_4.f90
===================================================================
--- gcc/testsuite/gfortran.dg/assumed_type_4.f90	(Revision 184855)
+++ gcc/testsuite/gfortran.dg/assumed_type_4.f90	(Arbeitskopie)
@@ -5,6 +5,6 @@ 
 !
 ! Test TYPE(*)
 
-subroutine one(a) ! { dg-error "TS 29113: Assumed type" }
-  type(*)  :: a
+subroutine one(a)
+  type(*)  :: a ! { dg-error "TS 29113: Assumed type" }
 end subroutine one
Index: gcc/testsuite/gfortran.dg/assumed_type_3.f90
===================================================================
--- gcc/testsuite/gfortran.dg/assumed_type_3.f90	(Revision 184855)
+++ gcc/testsuite/gfortran.dg/assumed_type_3.f90	(Arbeitskopie)
@@ -5,6 +5,11 @@ 
 !
 ! Test TYPE(*)
 
+subroutine fourteen(x)
+  type(*) :: x
+  x = x ! { dg-error "Invalid expression with assumed-type variable" }
+end subroutine fourteen
+
 subroutine one(a) ! { dg-error "may not have the ALLOCATABLE, CODIMENSION, POINTER or VALUE attribute" }
   type(*), value :: a
 end subroutine one
@@ -52,10 +57,10 @@  subroutine nine()
     subroutine okay2(x)
       type(*) :: x(*)
     end subroutine okay2
-    subroutine okay2(x,y)
+    subroutine okay3(x,y)
       integer :: x
       type(*) :: y
-    end subroutine okay2
+    end subroutine okay3
   end interface
   interface two
     subroutine okok1(x)
@@ -100,10 +105,10 @@  end subroutine eleven
 
 subroutine twelf(x)
   type(*) :: x
-  call bar(x)
+  call bar(x) ! { dg-error "Type mismatch in argument" }
 contains
   subroutine bar(x)
-    integer :: x ! { dg-error "Type mismatch in argument" }
+    integer :: x
   end subroutine bar
 end subroutine twelf
 
@@ -113,7 +118,4 @@  subroutine thirteen(x, y)
   print *, ubound(y, dim=x) ! { dg-error "must be INTEGER" }
 end subroutine thirteen
 
-subroutine fourteen(x)
-  type(*) :: x
-  x = x ! { dg-error "Invalid expression with assumed-type variable" }
-end subroutine fourteen
+