diff mbox

PATCH: Update gcc.target/i386/pr52146.c to allow $-18874240

Message ID 20120302202453.GA2034@intel.com
State New
Headers show

Commit Message

H.J. Lu March 2, 2012, 8:24 p.m. UTC 
Hi,

X32 may generate

	movl	$-18874240, %eax
	movl	(%eax), %eax

This patchs allows $-18874240.  OK for trunk?

Thanks.


H.J.
---
2012-02-10  H.J. Lu  <hongjiu.lu@intel.com>

	PR target/52146
	* gcc.target/i386/pr52146.c: Update final-scan to allow $-18874240.

Comments

Uros Bizjak March 4, 2012, 7:06 p.m. UTC | #1 
On Fri, Mar 2, 2012 at 9:24 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:

> X32 may generate
>
>        movl    $-18874240, %eax
>        movl    (%eax), %eax
>
> This patchs allows $-18874240.  OK for trunk?

Ah, it took me a while to note the dollar sign difference. We want to
prevent only:

movl    $0, -18874240

and not the sequence you point out.

The patch is OK everywhere.

Thanks,
Uros.
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/i386/pr52146.c b/gcc/testsuite/gcc.target/i386/pr52146.c
index a4804e6..4eb91c0 100644
--- a/gcc/testsuite/gcc.target/i386/pr52146.c
+++ b/gcc/testsuite/gcc.target/i386/pr52146.c
@@ -15,4 +15,4 @@  test2 (void)
   *apic_tpr_addr = 0;
 }
 
-/* { dg-final { scan-assembler-not "-18874240" } } */
+/* { dg-final { scan-assembler-not "\[,\\t \]+-18874240" } } */