From patchwork Fri Mar 2 19:13:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 144312 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 930D4B6FA2 for ; Sat, 3 Mar 2012 06:13:37 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1331320417; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To: Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=HCZyK3oA75KCqxv2NCWuyBa3+8Q=; b=bIDKcS0aK8NGBc2iC0Yc84MqqAgRHDvL86Dhp8RZm4dkUUGeId+z+mdBK8RppQ mXm0rw96e4dCb3VvcfkZeZ33TM180S3Tvds7F9po8XHBZ/UUMgdjUKgwzSyfL3DO s0DtBT1oAGTshsqT5J7kENmdLAwX/RD6lyjAGJB3r9lbk= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=hJZgMq0gZhHVA0TBLa4CBKYji1W/kC0oK02VjKRwTTefYqRDNtQzCbYG/GQy4J CjvlNtOgpa5t6m4+gnZ4iBmRgTItyPV5wmRRn468l2HZjEe4ycNSABhgWEldt0vQ rUztiLpRJ0cKgzpxVFB6GIIMIPDmGI6Mt6e2nYiB3g8qQ=; Received: (qmail 31089 invoked by alias); 2 Mar 2012 19:13:31 -0000 Received: (qmail 31077 invoked by uid 22791); 2 Mar 2012 19:13:29 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, TW_CC, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Mar 2012 19:13:16 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 8DDC7DFC; Fri, 2 Mar 2012 20:13:14 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id uaB9K6ZEurD5; Fri, 2 Mar 2012 20:13:12 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 39F86DFB; Fri, 2 Mar 2012 20:13:10 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id q22JD9hN020754; Fri, 2 Mar 2012 20:13:09 +0100 (MET) From: Rainer Orth To: Ian Lance Taylor Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Re: libgo patch committed: Update to weekly.2012-02-14 release References: Date: Fri, 02 Mar 2012 20:13:09 +0100 In-Reply-To: (Ian Lance Taylor's message of "Fri, 02 Mar 2012 08:38:51 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Ian Lance Taylor writes: > I have committed a patch to libgo to update to the weekly.2012-02-14 > release. As usual, in this e-mail message I only include the patches to > files specific to the gccgo version of libgo. Bootstrapped and ran Go > testsuite on x86_64-unknown-linux-gnu. Committed to mainline. This broke Solaris 10 (and probably 9 also) bootstrap: /vol/gcc/src/hg/trunk/local/libgo/runtime/mem.c: In function 'mmap_fixed': /vol/gcc/src/hg/trunk/local/libgo/runtime/mem.c:47:2: error: pointer targets in passing argument 1 of 'mmap' differ in signedness [-Werror=pointer-sign] In file included from /vol/gcc/src/hg/trunk/local/libgo/runtime/runtime.h:23:0, from /vol/gcc/src/hg/trunk/local/libgo/runtime/mem.c:8: /usr/include/sys/mman.h:168:16: note: expected 'caddr_t' but argument is of type 'byte *' /vol/gcc/src/hg/trunk/local/libgo/runtime/mem.c:53:3: error: pointer targets in passing argument 1 of 'mmap' differ in signedness [-Werror=pointer-sign] In file included from /vol/gcc/src/hg/trunk/local/libgo/runtime/runtime.h:23:0, from /vol/gcc/src/hg/trunk/local/libgo/runtime/mem.c:8: /usr/include/sys/mman.h:168:16: note: expected 'caddr_t' but argument is of type 'byte *' cc1: all warnings being treated as errors The first mmap arg is caddr_t (char *), while byte * is uint8 *. Casting to void * fixes this. Rainer # HG changeset patch # Parent 3c65bd27734429765e18be13aeb46e624807b984 Cast mmap addr to void * diff --git a/libgo/runtime/mem.c b/libgo/runtime/mem.c --- a/libgo/runtime/mem.c +++ b/libgo/runtime/mem.c @@ -44,13 +44,13 @@ mmap_fixed(byte *v, uintptr n, int32 pro { void *p; - p = runtime_mmap(v, n, prot, flags, fd, offset); + p = runtime_mmap((void *)v, n, prot, flags, fd, offset); if(p != v && addrspace_free(v, n)) { // On some systems, mmap ignores v without // MAP_FIXED, so retry if the address space is free. if(p != MAP_FAILED) runtime_munmap(p, n); - p = runtime_mmap(v, n, prot, flags|MAP_FIXED, fd, offset); + p = runtime_mmap((void *)v, n, prot, flags|MAP_FIXED, fd, offset); } return p; }