From patchwork Fri Mar 2 15:11:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: santosh nayak X-Patchwork-Id: 144273 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E7D76100810 for ; Sat, 3 Mar 2012 02:12:49 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758440Ab2CBPMe (ORCPT ); Fri, 2 Mar 2012 10:12:34 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:42273 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755856Ab2CBPMc (ORCPT ); Fri, 2 Mar 2012 10:12:32 -0500 Received: by pbcun15 with SMTP id un15so200587pbc.19 for ; Fri, 02 Mar 2012 07:12:32 -0800 (PST) Received-SPF: pass (google.com: domain of santoshprasadnayak@gmail.com designates 10.68.219.130 as permitted sender) client-ip=10.68.219.130; Authentication-Results: mr.google.com; spf=pass (google.com: domain of santoshprasadnayak@gmail.com designates 10.68.219.130 as permitted sender) smtp.mail=santoshprasadnayak@gmail.com; dkim=pass header.i=santoshprasadnayak@gmail.com Received: from mr.google.com ([10.68.219.130]) by 10.68.219.130 with SMTP id po2mr17284984pbc.140.1330701152091 (num_hops = 1); Fri, 02 Mar 2012 07:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=QtX/knjxxFi60hdvISH+KRKqK0HnBk5abRq6v14/0Gw=; b=KYnumBbAmsc+4yvSpnktPHA6gbII8mlFu+Zzyt88NBdWwbbQ8AKA8YT1slsGtsQL+c 1bB6/IspO6iboflxOxlpmj9nAFNB+OGJG4x/heuooy2rSoGiSaeTLWXmahQRc+b53rqk 2FF1ZB8KlehTcF52Mz3ilZ4fc6tstIUzepfzrx+Sly5yGrmEfcBOCHW7yxFNaRzMpy4w XC1FCYUpPBS8XhbcQOenZulBy5mRR6OsIme+9Zq24RDzNVMjkTENvwjih+bvSzhaGGAq 3F2TIz6D6W+69kQPFeALPjdQZzuJEKnkRvULe4vHI3Z3qCDrmSZ/9zDDlUf0qr82PrtT eu5w== Received: by 10.68.219.130 with SMTP id po2mr14444284pbc.140.1330701152045; Fri, 02 Mar 2012 07:12:32 -0800 (PST) Received: from localhost.localdomain ([14.97.60.126]) by mx.google.com with ESMTPS id x1sm5221293pbp.50.2012.03.02.07.12.28 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 02 Mar 2012 07:12:31 -0800 (PST) From: santosh nayak To: sony.chacko@qlogic.com Cc: rajesh.borundia@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Santosh Nayak Subject: [PATCH 3/3] netxen: qlogic ethernet : Fix Endian Bug. Date: Fri, 2 Mar 2012 20:41:39 +0530 Message-Id: <1330701099-18281-1-git-send-email-santoshprasadnayak@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Santosh Nayak Fix endian bug. Add a default case in 'netxen_list_config_vlan_ip' Signed-off-by: Santosh Nayak --- .../net/ethernet/qlogic/netxen/netxen_nic_main.c | 20 ++++++++++++-------- 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c index 8dc4a134..971b286 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c @@ -818,7 +818,7 @@ netxen_check_options(struct netxen_adapter *adapter) adapter->driver_mismatch = 1; return; } - ptr32[i] = cpu_to_le32(val); + ptr32[i] = val; offset += sizeof(u32); } @@ -3028,7 +3028,7 @@ netxen_list_config_vlan_ip(struct netxen_adapter *adapter, list_for_each(head, &adapter->vlan_ip_list) { cur = list_entry(head, struct nx_vlan_ip_list, list); - if (cur->ip_addr == ifa->ifa_address) + if (cur->ip_addr == be32_to_cpu(ifa->ifa_address)) return; } @@ -3039,18 +3039,22 @@ netxen_list_config_vlan_ip(struct netxen_adapter *adapter, return; } - cur->ip_addr = ifa->ifa_address; + cur->ip_addr = be32_to_cpu(ifa->ifa_address); list_add_tail(&cur->list, &adapter->vlan_ip_list); break; case NX_IP_DOWN: list_for_each_entry_safe(cur, tmp_cur, &adapter->vlan_ip_list, list) { - if (cur->ip_addr == ifa->ifa_address) { + if (cur->ip_addr == be32_to_cpu(ifa->ifa_address)) { list_del(&cur->list); kfree(cur); break; } } + break; + default: + printk(KERN_ERR "%ld: Wrong event id \n", event); + break; } } static void @@ -3070,12 +3074,12 @@ netxen_config_indev_addr(struct netxen_adapter *adapter, switch (event) { case NETDEV_UP: netxen_config_ipaddr(adapter, - ifa->ifa_address, NX_IP_UP); + be32_to_cpu(ifa->ifa_address), NX_IP_UP); netxen_list_config_vlan_ip(adapter, ifa, NX_IP_UP); break; case NETDEV_DOWN: netxen_config_ipaddr(adapter, - ifa->ifa_address, NX_IP_DOWN); + be32_to_cpu(ifa->ifa_address), NX_IP_DOWN); netxen_list_config_vlan_ip(adapter, ifa, NX_IP_DOWN); break; default: @@ -3167,11 +3171,11 @@ recheck: switch (event) { case NETDEV_UP: - netxen_config_ipaddr(adapter, ifa->ifa_address, NX_IP_UP); + netxen_config_ipaddr(adapter, be32_to_cpu(ifa->ifa_address), NX_IP_UP); netxen_list_config_vlan_ip(adapter, ifa, NX_IP_UP); break; case NETDEV_DOWN: - netxen_config_ipaddr(adapter, ifa->ifa_address, NX_IP_DOWN); + netxen_config_ipaddr(adapter, be32_to_cpu(ifa->ifa_address), NX_IP_DOWN); netxen_list_config_vlan_ip(adapter, ifa, NX_IP_DOWN); break; default: