From patchwork Fri Mar 2 15:09:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: santosh nayak X-Patchwork-Id: 144271 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AF390B6EF1 for ; Sat, 3 Mar 2012 02:10:23 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757487Ab2CBPKC (ORCPT ); Fri, 2 Mar 2012 10:10:02 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:46667 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215Ab2CBPKA (ORCPT ); Fri, 2 Mar 2012 10:10:00 -0500 Received: by pbcun15 with SMTP id un15so198006pbc.19 for ; Fri, 02 Mar 2012 07:10:00 -0800 (PST) Received-SPF: pass (google.com: domain of santoshprasadnayak@gmail.com designates 10.68.232.103 as permitted sender) client-ip=10.68.232.103; Authentication-Results: mr.google.com; spf=pass (google.com: domain of santoshprasadnayak@gmail.com designates 10.68.232.103 as permitted sender) smtp.mail=santoshprasadnayak@gmail.com; dkim=pass header.i=santoshprasadnayak@gmail.com Received: from mr.google.com ([10.68.232.103]) by 10.68.232.103 with SMTP id tn7mr17187244pbc.54.1330701000019 (num_hops = 1); Fri, 02 Mar 2012 07:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=8lsqjv4Fi4pBcrsqXM1etXMB+ilW3qv/2zwovRDofbc=; b=shAuonwkUlJfFjhwZ1AyLhFoz90zbvRmV9ZRNA0gVxD+awSuHVb4YxaOxwnbYnz+Ku 0B+aH+DQv500qRoSvY8UMorEbxpY0IBtPLIDN1ohYcsJF2auuMU4myUT0mgF5Wzgil4o py9Ugm+6GebxZeXjjQMU91eQTX4GgBwpjfj22sLt/gGymCvpzmLFZi7Kp6OzVtPiudtq qf2A52laa4lZyC4F0vWTNq0iTZ5/Bw80W1Z0RXILX0HnZo/kQxwTM7H49HMBNTfQkPNT CAgHe98AMPq4BsCa68O/pe1oCQ60Huq85O58opysNPb10+7cca7Psf8OTGQrCpqfqfFW BBGg== Received: by 10.68.232.103 with SMTP id tn7mr14375362pbc.54.1330700999804; Fri, 02 Mar 2012 07:09:59 -0800 (PST) Received: from localhost.localdomain ([14.97.60.126]) by mx.google.com with ESMTPS id d4sm5222870pbe.36.2012.03.02.07.09.56 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 02 Mar 2012 07:09:59 -0800 (PST) From: santosh nayak To: jitendra.kalsaria@qlogic.com Cc: ron.mercer@qlogic.com, linux-driver@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Santosh Nayak Subject: [PATCH 1/3] qla3xxx: ethernet: Fix bogus interrupt state flag. Date: Fri, 2 Mar 2012 20:39:05 +0530 Message-Id: <1330700945-18195-1-git-send-email-santoshprasadnayak@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Santosh Nayak In 'ql_adapter_initialize' the first call for 'spin_unlock_irqrestore()' is with hw_flags = 0, which is as good as 'spin_unlock_irq()' (unconditional interrupt enabling). If this is intended, then for better performance 'spin_unlock_irqrestore()' can be replaced with 'spin_unlock_irq()' and 'spin_lock_irqsave()' can be replaced by 'spin_lock_irq() Signed-off-by: Santosh Nayak --- drivers/net/ethernet/qlogic/qla3xxx.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c index d49f6da..8da3e41 100644 --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -3017,7 +3017,6 @@ static int ql_adapter_initialize(struct ql3_adapter *qdev) (void __iomem *)port_regs; u32 delay = 10; int status = 0; - unsigned long hw_flags = 0; if (ql_mii_setup(qdev)) return -1; @@ -3228,9 +3227,9 @@ static int ql_adapter_initialize(struct ql3_adapter *qdev) value = ql_read_page0_reg(qdev, &port_regs->portStatus); if (value & PORT_STATUS_IC) break; - spin_unlock_irqrestore(&qdev->hw_lock, hw_flags); + spin_unlock_irq(&qdev->hw_lock); msleep(500); - spin_lock_irqsave(&qdev->hw_lock, hw_flags); + spin_lock_irq(&qdev->hw_lock); } while (--delay); if (delay == 0) {