Patchwork [2/2] hpet: hpet_check: make func args const where possible

login
register
mail settings
Submitter Colin King
Date March 2, 2012, 11:28 a.m.
Message ID <1330687688-30180-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/144222/
State Accepted
Headers show

Comments

Colin King - March 2, 2012, 11:28 a.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/hpet/hpet_check/hpet_check.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Keng-Yu Lin - March 5, 2012, 9:53 a.m.
On Fri, Mar 2, 2012 at 7:28 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/hpet/hpet_check/hpet_check.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/hpet/hpet_check/hpet_check.c b/src/hpet/hpet_check/hpet_check.c
> index 79dfae9..b999c99 100644
> --- a/src/hpet/hpet_check/hpet_check.c
> +++ b/src/hpet/hpet_check/hpet_check.c
> @@ -56,7 +56,7 @@ static void check_hpet_base_hpet(void)
>  #endif
>
>  static void hpet_parse_check_base(fwts_framework *fw,
> -       char *table, fwts_list_link *item)
> +       const char *table, fwts_list_link *item)
>  {
>        char *val, *idx;
>
> @@ -88,7 +88,7 @@ static void hpet_parse_check_base(fwts_framework *fw,
>  }
>
>  static void hpet_parse_device_hpet(fwts_framework *fw,
> -       char *table, fwts_list_link *item)
> +       const char *table, fwts_list_link *item)
>  {
>        for (;item != NULL; item = item->next) {
>                char *str = fwts_text_list_text(item);
> @@ -126,7 +126,7 @@ static void hpet_parse_device_hpet(fwts_framework *fw,
>  *     used to parse the DSDT for HPET base info
>  */
>  static void hpet_check_base_acpi_table(fwts_framework *fw,
> -       char *table, int which)
> +       const char *table, const int which)
>  {
>        fwts_list *output;
>        fwts_list_link *item;
> --
> 1.7.9
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - March 6, 2012, 8:56 a.m.
On 03/02/2012 07:28 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/hpet/hpet_check/hpet_check.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/hpet/hpet_check/hpet_check.c b/src/hpet/hpet_check/hpet_check.c
> index 79dfae9..b999c99 100644
> --- a/src/hpet/hpet_check/hpet_check.c
> +++ b/src/hpet/hpet_check/hpet_check.c
> @@ -56,7 +56,7 @@ static void check_hpet_base_hpet(void)
>   #endif
>
>   static void hpet_parse_check_base(fwts_framework *fw,
> -	char *table, fwts_list_link *item)
> +	const char *table, fwts_list_link *item)
>   {
>   	char *val, *idx;
>
> @@ -88,7 +88,7 @@ static void hpet_parse_check_base(fwts_framework *fw,
>   }
>
>   static void hpet_parse_device_hpet(fwts_framework *fw,
> -	char *table, fwts_list_link *item)
> +	const char *table, fwts_list_link *item)
>   {
>   	for (;item != NULL; item = item->next) {
>   		char *str = fwts_text_list_text(item);
> @@ -126,7 +126,7 @@ static void hpet_parse_device_hpet(fwts_framework *fw,
>    *	used to parse the DSDT for HPET base info
>    */
>   static void hpet_check_base_acpi_table(fwts_framework *fw,
> -	char *table, int which)
> +	const char *table, const int which)
>   {
>   	fwts_list *output;
>   	fwts_list_link *item;
Acked-by: Alex Hung<alex.hung@canonical.com>

Patch

diff --git a/src/hpet/hpet_check/hpet_check.c b/src/hpet/hpet_check/hpet_check.c
index 79dfae9..b999c99 100644
--- a/src/hpet/hpet_check/hpet_check.c
+++ b/src/hpet/hpet_check/hpet_check.c
@@ -56,7 +56,7 @@  static void check_hpet_base_hpet(void)
 #endif
 
 static void hpet_parse_check_base(fwts_framework *fw,
-	char *table, fwts_list_link *item)
+	const char *table, fwts_list_link *item)
 {
 	char *val, *idx;
 
@@ -88,7 +88,7 @@  static void hpet_parse_check_base(fwts_framework *fw,
 }
 
 static void hpet_parse_device_hpet(fwts_framework *fw,
-	char *table, fwts_list_link *item)
+	const char *table, fwts_list_link *item)
 {
 	for (;item != NULL; item = item->next) {
 		char *str = fwts_text_list_text(item);
@@ -126,7 +126,7 @@  static void hpet_parse_device_hpet(fwts_framework *fw,
  *	used to parse the DSDT for HPET base info
  */
 static void hpet_check_base_acpi_table(fwts_framework *fw,
-	char *table, int which)
+	const char *table, const int which)
 {
 	fwts_list *output;
 	fwts_list_link *item;