From patchwork Fri Mar 2 10:04:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 144190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 70D861007D3 for ; Fri, 2 Mar 2012 21:04:28 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1331287469; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To: Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=hRiujoHHSRAvTqxAFzuLh7Lttb8=; b=Zj6WgTwRzcITsn+ccuoB2fBf49QPe7RqUkcDDB7PbonLnyWW/KNxuIqZFTEAGr MvTC9SrHyMfENMsAx7fADvKX2hM3HMS1XvXWgdkwzdjXDP6vZ3WDaoGtwBQJjLtq cnU4Q8lQZ4qt1Udgf39rODX7DufHMvMueP6qIk2/pbFqw= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=dnugSKAA/5i3JKY95J7LCDeQKmm3JVx1Y56KLk22oIRUhiXa4rJlUZQgesj1qe Ss4wsZqUJqORW90Ur1SZOUsAlRzj2u3HtbFLgsLSWWjTXlU52G3wQt/AFEjhXv9O E9B8+pi9AobhYGgjUpPSF9FfUlHIZY09fFfLebIo4Lpbg=; Received: (qmail 16113 invoked by alias); 2 Mar 2012 10:04:20 -0000 Received: (qmail 16103 invoked by uid 22791); 2 Mar 2012 10:04:18 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Mar 2012 10:04:04 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 5AC4CE5; Fri, 2 Mar 2012 11:04:03 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id q37WfyUcwN9L; Fri, 2 Mar 2012 11:04:01 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id 6C63DE4; Fri, 2 Mar 2012 11:04:01 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id q22A40tJ020096; Fri, 2 Mar 2012 11:04:00 +0100 (MET) From: Rainer Orth To: Ian Lance Taylor Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Re: libgo patch committed: Fill out syscall package for GNU/Linux References: Date: Fri, 02 Mar 2012 11:04:00 +0100 In-Reply-To: (Ian Lance Taylor's message of "Wed, 29 Feb 2012 12:02:34 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Ian Lance Taylor writes: > This patch to libgo fills out the syscall package for GNU/Linux to match > all the functions in the syscall package in the master Go library. > There is a test case for this patch at > http://code.google.com/p/go/issues/detail?id=3071 . Bootstrapped and > ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Unfortunately, this broke Solaris bootstrap: /usr/include/sys/ustat.h:31:2: error: #error "Cannot use ustat in the large files compilation environment" make[4]: *** No rule to make target `s-sysinfo', needed by `sysinfo.go'. Stop. make[4]: *** Waiting for unfinished jobs.... has #if !defined(_LP64) && _FILE_OFFSET_BITS == 64 #error "Cannot use ustat in the large files compilation environment" #endif I've used the hack below to restore bootstrap, but suppose a cleaner solution would be to run the configure tests with the same flags as used for the actual compilations (i.e. OSCFLAGS). Alternatively, one could restrict the use of to Linux since it's only used in go/syscall/libcall_linux.go anyway. Rainer # HG changeset patch # Parent d7ca4c137cbff062787505281b123c22dfc72019 Don't use on 32-bit Solaris diff --git a/libgo/mksysinfo.sh b/libgo/mksysinfo.sh --- a/libgo/mksysinfo.sh +++ b/libgo/mksysinfo.sh @@ -110,8 +110,12 @@ cat > sysinfo.c < #endif #if defined(HAVE_USTAT_H) +#if defined(__sun__) && defined(__svr4__) && !defined(_LP64) && _FILE_OFFSET_BITS == 64 +/* Solaris is incompatible with largefiles. */ +#else #include #endif +#endif #if defined(HAVE_UTIME_H) #include #endif