Patchwork [2/2] bios: hdaaudio: ensure source fits into 80 columns

login
register
mail settings
Submitter Colin King
Date March 2, 2012, 9:52 a.m.
Message ID <1330681947-17406-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/144183/
State Accepted
Headers show

Comments

Colin King - March 2, 2012, 9:52 a.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/bios/hdaaudio/hdaaudio.c |   15 +++++++++++----
 1 files changed, 11 insertions(+), 4 deletions(-)
Keng-Yu Lin - March 5, 2012, 9:02 a.m.
On Fri, Mar 2, 2012 at 5:52 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/bios/hdaaudio/hdaaudio.c |   15 +++++++++++----
>  1 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c
> index 7dc1823..1b6f88f 100644
> --- a/src/bios/hdaaudio/hdaaudio.c
> +++ b/src/bios/hdaaudio/hdaaudio.c
> @@ -71,7 +71,8 @@ static void hda_audio_dump_pins(fwts_framework *fw, const char *config,
>                        hda_audio_pin_setting *pin_setting =
>                                fwts_list_data(hda_audio_pin_setting *, item);
>
> -                       fwts_log_info_verbatum(fw, "  0x%4.4hx 0x%8.8x", pin_setting->pin, pin_setting->setting);
> +                       fwts_log_info_verbatum(fw, "  0x%4.4hx 0x%8.8x",
> +                               pin_setting->pin, pin_setting->setting);
>                }
>        } else
>                fwts_log_info(fw, "%s: None Defined.", config);
> @@ -131,10 +132,16 @@ static int hda_audio_check_pins(fwts_framework *fw, const char *path)
>        }
>
>        if (warn) {
> -               fwts_log_warning(fw, "BIOS pin configurations required software override to make HDA audio work correctly.");
> -               fwts_log_advice(fw, "The driver or user provided overrides should be corrected in BIOS firmware.");
> +               fwts_log_warning(fw,
> +                       "BIOS pin configurations required software override "
> +                       "to make HDA audio work correctly.");
> +               fwts_log_advice(fw,
> +                       "The driver or user provided overrides should be "
> +                       "corrected in BIOS firmware.");
>        } else
> -               fwts_passed(fw, "Default BIOS pin configurations did not have software override.");
> +               fwts_passed(fw,
> +                       "Default BIOS pin configurations did not have "
> +                       "software override.");
>
>        fwts_list_free_items(&user_pin_configs, free);
>        fwts_list_free_items(&driver_pin_configs, free);
> --
> 1.7.9
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - March 7, 2012, 9:54 a.m.
On 03/02/2012 05:52 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/bios/hdaaudio/hdaaudio.c |   15 +++++++++++----
>   1 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c
> index 7dc1823..1b6f88f 100644
> --- a/src/bios/hdaaudio/hdaaudio.c
> +++ b/src/bios/hdaaudio/hdaaudio.c
> @@ -71,7 +71,8 @@ static void hda_audio_dump_pins(fwts_framework *fw, const char *config,
>   			hda_audio_pin_setting *pin_setting =
>   				fwts_list_data(hda_audio_pin_setting *, item);
>
> -			fwts_log_info_verbatum(fw, "  0x%4.4hx 0x%8.8x", pin_setting->pin, pin_setting->setting);
> +			fwts_log_info_verbatum(fw, "  0x%4.4hx 0x%8.8x",
> +				pin_setting->pin, pin_setting->setting);
>   		}
>   	} else
>   		fwts_log_info(fw, "%s: None Defined.", config);
> @@ -131,10 +132,16 @@ static int hda_audio_check_pins(fwts_framework *fw, const char *path)
>   	}
>
>   	if (warn) {
> -		fwts_log_warning(fw, "BIOS pin configurations required software override to make HDA audio work correctly.");
> -		fwts_log_advice(fw, "The driver or user provided overrides should be corrected in BIOS firmware.");
> +		fwts_log_warning(fw,
> +			"BIOS pin configurations required software override "
> +			"to make HDA audio work correctly.");
> +		fwts_log_advice(fw,
> +			"The driver or user provided overrides should be "
> +			"corrected in BIOS firmware.");
>   	} else
> -		fwts_passed(fw, "Default BIOS pin configurations did not have software override.");
> +		fwts_passed(fw,
> +			"Default BIOS pin configurations did not have "
> +			"software override.");
>
>   	fwts_list_free_items(&user_pin_configs, free);
>   	fwts_list_free_items(&driver_pin_configs, free);
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c
index 7dc1823..1b6f88f 100644
--- a/src/bios/hdaaudio/hdaaudio.c
+++ b/src/bios/hdaaudio/hdaaudio.c
@@ -71,7 +71,8 @@  static void hda_audio_dump_pins(fwts_framework *fw, const char *config,
 			hda_audio_pin_setting *pin_setting =
 				fwts_list_data(hda_audio_pin_setting *, item);
 
-			fwts_log_info_verbatum(fw, "  0x%4.4hx 0x%8.8x", pin_setting->pin, pin_setting->setting);
+			fwts_log_info_verbatum(fw, "  0x%4.4hx 0x%8.8x",
+				pin_setting->pin, pin_setting->setting);
 		}
 	} else
 		fwts_log_info(fw, "%s: None Defined.", config);
@@ -131,10 +132,16 @@  static int hda_audio_check_pins(fwts_framework *fw, const char *path)
 	}
 
 	if (warn) {
-		fwts_log_warning(fw, "BIOS pin configurations required software override to make HDA audio work correctly.");
-		fwts_log_advice(fw, "The driver or user provided overrides should be corrected in BIOS firmware.");
+		fwts_log_warning(fw,
+			"BIOS pin configurations required software override "
+			"to make HDA audio work correctly.");
+		fwts_log_advice(fw,
+			"The driver or user provided overrides should be "
+			"corrected in BIOS firmware.");
 	} else
-		fwts_passed(fw, "Default BIOS pin configurations did not have software override.");
+		fwts_passed(fw,
+			"Default BIOS pin configurations did not have "
+			"software override.");
 
 	fwts_list_free_items(&user_pin_configs, free);
 	fwts_list_free_items(&driver_pin_configs, free);